Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkpoint module utils and service tcp module for example #52932

Open
wants to merge 9 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@chkp-orso
Copy link

chkp-orso commented Feb 25, 2019

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 25, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:76:0: missing-final-newline Final newline missing
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:76:0: mixed-line-endings Mixed line endings LF and CRLF

The test ansible-test sanity --test docs-build [explain] failed with 6 errors:

docs/docsite/rst/modules/checkpoint_service_tcp_facts_module.rst:9:0: duplicate-label: duplicate label checkpoint_host_facts_module, other instance in /root/ansible/docs/docsite/rst/modules/checkpoint_host_facts_module.rst
docs/docsite/rst/modules/checkpoint_service_tcp_module.rst:9:0: duplicate-label: duplicate label checkpoint_host_module, other instance in /root/ansible/docs/docsite/rst/modules/checkpoint_host_module.rst
docs/docsite/rst/modules/list_of_all_modules.rst:571:0: undefined-label: undefined label: checkpoint_service_tcp_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_all_modules.rst:572:0: undefined-label: undefined label: checkpoint_service_tcp_facts_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_network_modules.rst:266:0: undefined-label: undefined label: checkpoint_service_tcp_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_network_modules.rst:267:0: undefined-label: undefined label: checkpoint_service_tcp_facts_module (if the link has no caption the label must precede a section header)

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:76:11: W292 no newline at end of file

The test ansible-test sanity --test validate-modules [explain] failed with 13 errors:

lib/ansible/modules/network/checkpoint/checkpoint_service_tcp.py:0:0: E305 DOCUMENTATION.module: not a valid value for dictionary value @ data['module']. Got 'checkpoint_host'
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp.py:0:0: E322 Argument 'api_call_object' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp.py:0:0: E322 Argument 'parameters' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp.py:0:0: E323 Argument 'ip_address' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp.py:0:0: E323 Argument 'name' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp.py:0:0: E325 Argument 'policy_package' in argument_spec defines type as 'str' but documentation defines type as 'bool'
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:0:0: E305 DOCUMENTATION.module: not a valid value for dictionary value @ data['module']. Got 'checkpoint_host_facts'
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:0:0: E322 Argument 'api_call_object' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:0:0: E322 Argument 'parameters' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:0:0: E322 Argument 'state' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:0:0: E323 Argument 'name' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:0:0: E323 Argument 'uid' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:0:0: E324 Argument 'state' in argument_spec defines default as ('present') but documentation defines default as (None)

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 25, 2019

@chkp-orso this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 25, 2019

@chkp-orso, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 28, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:76:0: missing-final-newline Final newline missing
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:76:0: mixed-line-endings Mixed line endings LF and CRLF

The test ansible-test sanity --test docs-build [explain] failed with 6 errors:

docs/docsite/rst/modules/checkpoint_service_tcp_facts_module.rst:9:0: duplicate-label: duplicate label checkpoint_host_facts_module, other instance in /root/ansible/docs/docsite/rst/modules/checkpoint_host_facts_module.rst
docs/docsite/rst/modules/checkpoint_service_tcp_module.rst:9:0: duplicate-label: duplicate label checkpoint_host_module, other instance in /root/ansible/docs/docsite/rst/modules/checkpoint_host_module.rst
docs/docsite/rst/modules/list_of_all_modules.rst:573:0: undefined-label: undefined label: checkpoint_service_tcp_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_all_modules.rst:574:0: undefined-label: undefined label: checkpoint_service_tcp_facts_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_network_modules.rst:266:0: undefined-label: undefined label: checkpoint_service_tcp_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_network_modules.rst:267:0: undefined-label: undefined label: checkpoint_service_tcp_facts_module (if the link has no caption the label must precede a section header)

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:76:11: W292 no newline at end of file

The test ansible-test sanity --test validate-modules [explain] failed with 13 errors:

lib/ansible/modules/network/checkpoint/checkpoint_service_tcp.py:0:0: E305 DOCUMENTATION.module: not a valid value for dictionary value @ data['module']. Got 'checkpoint_host'
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp.py:0:0: E322 Argument 'api_call_object' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp.py:0:0: E322 Argument 'parameters' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp.py:0:0: E323 Argument 'ip_address' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp.py:0:0: E323 Argument 'name' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp.py:0:0: E325 Argument 'policy_package' in argument_spec defines type as 'str' but documentation defines type as 'bool'
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:0:0: E305 DOCUMENTATION.module: not a valid value for dictionary value @ data['module']. Got 'checkpoint_host_facts'
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:0:0: E322 Argument 'api_call_object' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:0:0: E322 Argument 'parameters' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:0:0: E322 Argument 'state' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:0:0: E323 Argument 'name' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:0:0: E323 Argument 'uid' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/checkpoint/checkpoint_service_tcp_facts.py:0:0: E324 Argument 'state' in argument_spec defines default as ('present') but documentation defines default as (None)

click here for bot help

chkp-orso added some commits Mar 3, 2019

@ansibot ansibot removed the ci_verified label Mar 3, 2019

chkp-orso added some commits Mar 3, 2019

Revert "delete service tcp"
This reverts commit e768efd.
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 3, 2019

The test ansible-test sanity --test docs-build [explain] failed with 6 errors:

docs/docsite/rst/modules/checkpoint_network_facts_module.rst:9:0: duplicate-label: duplicate label checkpoint_host_module, other instance in /root/ansible/docs/docsite/rst/modules/checkpoint_host_module.rst
docs/docsite/rst/modules/checkpoint_network_module.rst:9:0: duplicate-label: duplicate label checkpoint_host_module, other instance in /root/ansible/docs/docsite/rst/modules/checkpoint_network_facts_module.rst
docs/docsite/rst/modules/list_of_all_modules.rst:578:0: undefined-label: undefined label: checkpoint_network_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_all_modules.rst:579:0: undefined-label: undefined label: checkpoint_network_facts_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_network_modules.rst:269:0: undefined-label: undefined label: checkpoint_network_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_network_modules.rst:270:0: undefined-label: undefined label: checkpoint_network_facts_module (if the link has no caption the label must precede a section header)

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/modules/network/checkpoint/checkpoint_network.py:125:5: E265 block comment should start with '# '
lib/ansible/modules/network/checkpoint/checkpoint_network.py:126:5: E265 block comment should start with '# '
lib/ansible/modules/network/checkpoint/checkpoint_network_facts.py:109:5: E265 block comment should start with '# '
lib/ansible/modules/network/checkpoint/checkpoint_network_facts.py:110:5: E265 block comment should start with '# '

The test ansible-test sanity --test validate-modules [explain] failed with 26 errors:

lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E305 DOCUMENTATION.module: not a valid value for dictionary value @ data['module']. Got 'checkpoint_host'
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E322 Argument 'broadcast' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E322 Argument 'color' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E322 Argument 'comments' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E322 Argument 'groups' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E322 Argument 'ignore_errors' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E322 Argument 'ignore_warnings' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E322 Argument 'mask_length' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E322 Argument 'mask_length4' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E322 Argument 'mask_length6' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E322 Argument 'nat_settings' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E322 Argument 'set_if_exists' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E322 Argument 'subnet' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E322 Argument 'subnet4' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E322 Argument 'subnet6' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E322 Argument 'subnet_mask' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E322 Argument 'tags' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E322 Argument 'uid' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E323 Argument 'ip_address' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/checkpoint/checkpoint_network.py:0:0: E325 Argument 'policy_package' in argument_spec defines type as 'str' but documentation defines type as 'bool'
lib/ansible/modules/network/checkpoint/checkpoint_network_facts.py:0:0: E305 DOCUMENTATION.module: not a valid value for dictionary value @ data['module']. Got 'checkpoint_host'
lib/ansible/modules/network/checkpoint/checkpoint_network_facts.py:0:0: E322 Argument 'details_level' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network_facts.py:0:0: E322 Argument 'uid' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/checkpoint/checkpoint_network_facts.py:0:0: E323 Argument 'ip_address' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/checkpoint/checkpoint_network_facts.py:0:0: E323 Argument 'state' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/checkpoint/checkpoint_network_facts.py:0:0: E325 Argument 'policy_package' in argument_spec defines type as 'str' but documentation defines type as 'bool'

click here for bot help

@mattclay mattclay added the ci_verified label Mar 6, 2019

@ansibot ansibot added the stale_ci label Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.