Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sentry_project module #52944

Open
wants to merge 19 commits into
base: devel
from

Conversation

@okgolove
Copy link
Contributor

okgolove commented Feb 25, 2019

SUMMARY

Module for manipulating Sentry projects.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

sentry_project

ADDITIONAL INFORMATION

I'm planning to add another modules related to Sentry.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 25, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/sentry_project.py:0:0: E312 No RETURN provided

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 25, 2019

@ansibot ansibot added the stale_ci label Mar 14, 2019

@okgolove okgolove force-pushed the okgolove:sentry_module branch from 8b2f968 to 2d3ed7b Mar 15, 2019

@okgolove

This comment has been minimized.

Copy link
Contributor Author

okgolove commented Mar 15, 2019

@Xaroth thank you for your review. I've fixed all you described before.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 15, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/sentry_project.py:105:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 7 errors:

lib/ansible/modules/web_infrastructure/sentry_project.py:61:124: W291 trailing whitespace
lib/ansible/modules/web_infrastructure/sentry_project.py:85:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/web_infrastructure/sentry_project.py:105:1: W293 blank line contains whitespace
lib/ansible/modules/web_infrastructure/sentry_project.py:107:7: E111 indentation is not a multiple of four
lib/ansible/modules/web_infrastructure/sentry_project.py:117:19: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/sentry_project.py:140:19: E121 continuation line under-indented for hanging indent
lib/ansible/modules/web_infrastructure/sentry_project.py:157:21: E122 continuation line missing indentation or outdented

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/sentry_project.py:0:0: E305 DOCUMENTATION.notes: not a valid value for dictionary value @ data['notes']. Got "Module supports check_mode, but it can't provide 100 percent gurantee what specified slug hasn't been used before."

click here for bot help

@okgolove

This comment has been minimized.

Copy link
Contributor Author

okgolove commented Mar 17, 2019

@felixfontein thank you for the review!

@felixfontein
Copy link
Contributor

felixfontein left a comment

Looks good. I did not test it, though. Would be nice if someone can test it!

@Andersson007

This comment has been minimized.

Copy link
Contributor

Andersson007 commented Mar 21, 2019

Hello, @okgolove ,
in addition to my review, what about CI tests ?

@tinproject

This comment has been minimized.

Copy link

tinproject commented Mar 21, 2019

It would be nice if it could support the same environment variables as the sentry-cli for parameters fallback.
https://docs.sentry.io/cli/configuration/

@okgolove

This comment has been minimized.

Copy link
Contributor Author

okgolove commented Mar 21, 2019

@tinproject cool idea. I'll check it. Thank you!

@okgolove

This comment has been minimized.

Copy link
Contributor Author

okgolove commented Mar 21, 2019

@Andersson007 I'll implement tests.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 21, 2019

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/sentry_project.py:88:3: key-duplicates EXAMPLES: duplication of key "sentry_project" in mapping

click here for bot help

@ansibot ansibot added ci_verified and removed ci_verified labels Mar 21, 2019

okgolove and others added some commits Feb 16, 2019

Some modifications
Support check_mode
Added default protocol for url
Changed default variable for url
Added sanity to error messages
Language fixes
Update lib/ansible/modules/web_infrastructure/sentry_project.py
Co-Authored-By: okgolove <36846182+okgolove@users.noreply.github.com>
Code style fixes
Added default types for all arguments
Changed function name
Code style fixes
Added type and require parameters for a "team" argument
Code style fixes
Added an absent example
Added a new line for author in the documentation
Added a comma for the last item of dict
Alphabetical order for the state argument
Added an alias for the organization argument
Removed unused import

@okgolove okgolove force-pushed the okgolove:sentry_module branch from c8f280e to 4f4c587 Mar 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.