Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fw via panorama connectivity to panos connection #52954

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@shinmog
Copy link
Contributor

shinmog commented Feb 25, 2019

SUMMARY

Adding additional functionality to allow the panos connection to connect to a firewall through a Panorama that is managing it.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

panos.py

ADDITIONAL INFORMATION

pandevice implements firewall via Panorama connectivity as a firewall.Firewall child of a panorama.Panorama, where the firewall.Firewall only has a serial number specified. This update implements that to support this additional connection option to the user.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 25, 2019

@@ -95,10 +96,11 @@ def get_pandevice_parent(self, module):
'pandevice', pandevice.__version__,
_vstr(self.min_pandevice_version)))

d, host_arg = None, None
d, host_arg, serial_number = None, None, None

This comment has been minimized.

@justjais

justjais Feb 27, 2019

Contributor

it would be great if you can rename d with some meaningful name.

@abenokraitis

This comment has been minimized.

Copy link
Contributor

abenokraitis commented Mar 4, 2019

@shinmog ^^^

@shinmog

This comment has been minimized.

Copy link
Contributor Author

shinmog commented Mar 5, 2019

Just doing a bit more testing to make sure this is the last time I'll have to update the connection code, then will update this PR.

@ansibot ansibot added community_review and removed needs_info labels Mar 5, 2019

@ansibot ansibot added the stale_ci label Mar 13, 2019

@shinmog

This comment has been minimized.

Copy link
Contributor Author

shinmog commented Mar 13, 2019

This update does a few things:

  • addresses review comments
  • changes the provider host param to ip_address (as this is how the PAN-OS hostname is currently given to all panos modules)
  • fixes a bug with checking for classic provider params (use .get() instead of assuming it is there)
@shinmog

This comment has been minimized.

Copy link
Contributor Author

shinmog commented Mar 13, 2019

@ansibot ansibot removed the stale_ci label Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.