Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AWSInventoryModule base class for common methods #52960

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@s-hertel
Copy link
Contributor

s-hertel commented Feb 26, 2019

SUMMARY

Remove duplicate code
Route53 and elasticache will also be able to use AWSInventoryModule

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

AWS inventory plugins

@ansibot

This comment was marked as resolved.

Copy link
Contributor

ansibot commented Feb 26, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/plugins/inventory/aws_ec2.py:270:22: undefined-variable Undefined variable 'get_session'

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/plugins/inventory/aws_ec2.py:262:5: E303 too many blank lines (2)
lib/ansible/plugins/inventory/aws_ec2.py:283:5: E303 too many blank lines (2)

click here for bot help

@s-hertel s-hertel force-pushed the s-hertel:aws_inventory_common_code branch 2 times, most recently from bfac3d4 to b744c37 Feb 26, 2019

@s-hertel s-hertel removed the needs_triage label Feb 26, 2019

@s-hertel s-hertel changed the title Make AWSInventoryModule base class for common methods [WIP] Make AWSInventoryModule base class for common methods Feb 26, 2019

@s-hertel

This comment was marked as resolved.

Copy link
Contributor Author

s-hertel commented Feb 26, 2019

need to look at failing test

@ansibot ansibot added the WIP label Feb 26, 2019

@s-hertel s-hertel force-pushed the s-hertel:aws_inventory_common_code branch from b179851 to 4d5f4d0 Feb 27, 2019

@s-hertel s-hertel changed the title [WIP] Make AWSInventoryModule base class for common methods Make AWSInventoryModule base class for common methods Feb 27, 2019

@s-hertel s-hertel force-pushed the s-hertel:aws_inventory_common_code branch from 4d5f4d0 to 7daa882 Feb 27, 2019

@ansibot ansibot added the stale_ci label Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.