Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql_user support REQUIRE NONE to remove a REQUIRE SSL "GRANT #52970

Open
wants to merge 12 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@Alexander198961
Copy link
Contributor

Alexander198961 commented Feb 26, 2019

Fixes for:
#53604
#29811
COMPONENT NAME
mysql_user
ANSIBLE VERSION
ansible 2.7.10

Need do some modifications

akovtunenko
@Alexander198961

This comment has been minimized.

Copy link
Contributor Author

Alexander198961 commented Feb 26, 2019

I will do some testing

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 26, 2019

@Alexander198961: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibot

This comment has been minimized.

akovtunenko
fix

akovtunenko added some commits Mar 3, 2019

akovtunenko
akovtunenko
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 3, 2019

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/mysql_user/tasks/ssl_connection.yml:1:1: empty-lines too many blank lines (1 > 0)

click here for bot help

@ansibot ansibot added the ci_verified label Mar 3, 2019

akovtunenko

@ansibot ansibot removed the ci_verified label Mar 4, 2019

akovtunenko
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 4, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/database/mysql/mysql_user.py:160:19: W291 trailing whitespace

click here for bot help

@ansibot ansibot added the ci_verified label Mar 4, 2019

akovtunenko
fix

@ansibot ansibot removed the ci_verified label Mar 4, 2019

akovtunenko added some commits Mar 10, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 10, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/database/mysql/mysql_user.py:562:1: E302 expected 2 blank lines, found 1

click here for bot help

akovtunenko
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/database/mysql/mysql_user.py:652:0: unnecessary-semicolon Unnecessary semicolon

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/database/mysql/mysql_user.py:243:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/database/mysql/mysql_user.py:651:5: E265 block comment should start with '# '
lib/ansible/modules/database/mysql/mysql_user.py:652:65: E703 statement ends with a semicolon

click here for bot help

akovtunenko
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/database/mysql/mysql_user.py:249:0: unnecessary-semicolon Unnecessary semicolon

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/database/mysql/mysql_user.py:248:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/database/mysql/mysql_user.py:249:65: E703 statement ends with a semicolon
lib/ansible/modules/database/mysql/mysql_user.py:257:1: E302 expected 2 blank lines, found 1

click here for bot help

@ansibot ansibot added the ci_verified label Mar 11, 2019

akovtunenko

@ansibot ansibot removed the ci_verified label Mar 11, 2019

@Alexander198961 Alexander198961 changed the title WIP mysql_user support REQUIRE NONE to remove a REQUIRE SSL "GRANT mysql_user support REQUIRE NONE to remove a REQUIRE SSL "GRANT Mar 11, 2019

@ansibot ansibot added community_review and removed WIP labels Mar 11, 2019

@ansibot ansibot added the stale_ci label Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.