Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ec2_asg_facts so it doesn't fail … #53017

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@dbanttari
Copy link
Contributor

dbanttari commented Feb 26, 2019

when using templates instead of configurations

SUMMARY

ec2_asg_facts attempts to create a key launch_config_name based off launch_configuration_name, but launch_configuration_name doesn't exist when launch templates are being used instead of launch configurations. With this (one-line) patch, the module no longer attempts to create launch_config_name when launch_configuration_name doesn't exist

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_asg_facts

ADDITIONAL INFORMATION

before:

fatal: [...]
File "/var/folders/pp/6dsttjzx4mb2sk3brgmc26s8trsq7b/T/ansible_pv_ec2_asg_facts_payload_fgl__3j1/__main__.py", line 366, in find_asgs
[...]
KeyError: 'launch_template_id'

after: module doesn't fail

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 26, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 26, 2019

@dbanttari, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@resmo

resmo approved these changes Feb 28, 2019

Copy link
Member

resmo left a comment

LGTM

@ansibot ansibot removed the needs_triage label Mar 1, 2019

@ansibot ansibot added the stale_ci label Mar 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.