Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix paramiko options #53037

Open
wants to merge 7 commits into
base: devel
Choose a base branch
from
Open

Fix paramiko options #53037

wants to merge 7 commits into from
+305 −139

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Feb 26, 2019 •
edited

fixes #52103

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

paramiko_ssh

@bcoca bcoca changed the title Fix paramiko options [WIP] Fix paramiko options Feb 26, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 26, 2019

cc @NilashishC @Qalthos @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. networking Network category new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Feb 26, 2019
@trishnaguha
Copy link
Member

cc @Qalthos

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 27, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 7, 2019
@bcoca bcoca changed the title [WIP] Fix paramiko options Fix paramiko options Mar 12, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. core_review In order to be merged, this PR must follow the core review workflow. labels Mar 12, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Mar 13, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Mar 21, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Mar 22, 2019
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed ci_verified Changes made in this PR are causing tests to fail. labels Mar 27, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Apr 3, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Apr 4, 2019
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Apr 21, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 29, 2021
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label May 31, 2021
Qalthos
Qalthos suggested changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@Qalthos Qalthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the current status on this is, but if this happens, the persistent doc fragments should have connect_timeout as well

lib/ansible/plugins/doc_fragments/connection_persistent.py Show resolved Hide resolved
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 22, 2021
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jan 5, 2022
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 5, 2022
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Mar 2, 2022
@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. and removed networking Network category labels Jul 12, 2023
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qalthos Qalthos Qalthos requested changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. collection Related to Ansible Collections work has_issue needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansible_paramiko_user is ignored
7 participants
@bcoca @ansibot @trishnaguha @samdoran @Qalthos @mattclay @eqrx