Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: make properties configurable #53050

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
6 participants
@Akasurde
Copy link
Member

Akasurde commented Feb 27, 2019

SUMMARY

This allows user to control set of properties which can be included
in the hostvars.

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/plugins/inventory/vmware_vm_inventory.py

VMware: make properties configurable
This allows user to control set of properties which can be included
in the hostvars.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 27, 2019

@Akasurde

This comment has been minimized.

Copy link
Member Author

Akasurde commented Feb 27, 2019

cc @angystardust I made properties configurable. This will help to improvise performance while gathering VM inventory.

@Akasurde

This comment has been minimized.

Copy link
Member Author

Akasurde commented Feb 27, 2019

@pdellaert @dericcrago @Im0 @jeking3 Could you please review this ?

@Akasurde Akasurde removed the needs_triage label Feb 27, 2019

@angystardust

This comment has been minimized.

Copy link
Contributor

angystardust commented Feb 27, 2019

One more thing I would like to have in the new inventories (both for vms and esxi hosts) that was possibile in the older inventory script is the alias_pattern parameter to alter the default inventory object names (so, for example, one can choose to strip the uuid)
Right now I’m editing the Python file in order to do that :)

@jeking3

This comment has been minimized.

Copy link
Contributor

jeking3 commented Feb 27, 2019

Does this build on the work I did in vmware_guest_facts and pyVmomi to extract raw vSphere API properties?

@Akasurde

This comment has been minimized.

Copy link
Member Author

Akasurde commented Mar 4, 2019

Does this build on the work I did in vmware_guest_facts and pyVmomi to extract raw vSphere API properties?

No. Since your fix is available in 6.7 and onwards. But I can include that change as well with fallback mechanism.

@adarobin
Copy link
Contributor

adarobin left a comment

LGTM

@alongchamps
Copy link

alongchamps left a comment

LGTM

@jeking3

This comment has been minimized.

Copy link
Contributor

jeking3 commented Mar 5, 2019

Does this build on the work I did in vmware_guest_facts and pyVmomi to extract raw vSphere API properties?

No. Since your fix is available in 6.7 and onwards. But I can include that change as well with fallback mechanism.

Just to clarify, you need pyvmomi>6.7.1 to get the pyVmomi json conversion of vSphere objects.

@ansibot ansibot added the stale_ci label Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.