Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inventory: find required binary for plugin to work #53052

Merged
merged 1 commit into from Mar 16, 2019

Conversation

Projects
None yet
4 participants
@Akasurde
Copy link
Member

Akasurde commented Feb 27, 2019

SUMMARY

Use existing "get_bin_path" API to find the binary path
required for inventory plugins to work.

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/plugins/inventory/nmap.py
lib/ansible/plugins/inventory/virtualbox.py

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 27, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/inventory/virtualbox.py:79:161: E501 line too long (162 > 160 characters)

click here for bot help

Show resolved Hide resolved lib/ansible/plugins/inventory/nmap.py Outdated

@Akasurde Akasurde force-pushed the Akasurde:find_bin branch from b06551e to e01787c Feb 28, 2019

@Akasurde Akasurde requested a review from bcoca Mar 4, 2019

inventory: find required binary for plugin to work
Use existing "get_bin_path" API to find the binary path
required for inventory plugins to work.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

@Akasurde Akasurde force-pushed the Akasurde:find_bin branch from e01787c to 42c1d89 Mar 5, 2019

@Akasurde Akasurde requested a review from bcoca Mar 15, 2019

@bcoca

bcoca approved these changes Mar 15, 2019

@Akasurde Akasurde merged commit b0306f5 into ansible:devel Mar 16, 2019

1 check passed

Shippable Run 111809 status is SUCCESS.
Details

@Akasurde Akasurde deleted the Akasurde:find_bin branch Mar 16, 2019

@sivel sivel removed the needs_triage label Mar 18, 2019

catcombo added a commit to catcombo/ansible that referenced this pull request Mar 21, 2019

inventory: find required binary for plugin to work (ansible#53052)
Use existing "get_bin_path" API to find the binary path
required for inventory plugins to work.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.