Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS SSM Connection Plugin Integration Tests #53105

Closed
wants to merge 59 commits into
base: devel
from

Conversation

Projects
None yet
6 participants
@gau1991
Copy link

gau1991 commented Feb 28, 2019

SUMMARY

This Pull Request covers the integration test for for AWS SSM Connection Plugin, introduced in the PR #49652

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

connection/aws_ssm

ADDITIONAL INFORMATION

This PR adds a integration test for AWS SSM Connection Plugin.

For execution following command can be used:

test/runner/ansible-test integration -v connection_aws_ssm --allow-unsupported

The integration tests are still marked as unsupported as they are failing with following issue:

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: UnicodeEncodeError: 'ascii' codec can't encode characters in position 5-6: ordinal not in range(128)
fatal: [test]: FAILED! => {"msg": "Unexpected failure during module execution.", "stdout": ""}

This need to be fixed from the AWS SSM Connection Plugin side.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 28, 2019

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

test/runner/lib/cli.py:319:0: bad-continuation Wrong continued indentation (add 2 spaces).                                               parents=[integration],                                               ^ |
test/runner/lib/cli.py:320:0: bad-continuation Wrong continued indentation (add 2 spaces).                                               help='aws ssm integration tests')                                               ^ |
test/runner/lib/cli.py:323:0: bad-continuation Wrong continued indentation (add 2 spaces).                                    targets=walk_aws_ssm_integration_targets,                                    ^ |
test/runner/lib/cli.py:324:0: bad-continuation Wrong continued indentation (add 2 spaces).                                    config=AwsSsmIntegrationConfig)                                    ^ |

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

test/runner/lib/cli.py:319:47: E128 continuation line under-indented for visual indent
test/runner/lib/cli.py:320:47: E128 continuation line under-indented for visual indent
test/runner/lib/cli.py:323:36: E128 continuation line under-indented for visual indent
test/runner/lib/cli.py:324:36: E128 continuation line under-indented for visual indent

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 28, 2019

Show resolved Hide resolved .gitignore Outdated
Show resolved Hide resolved test/integration/inventory.aws_ssm.template Outdated
Show resolved Hide resolved test/runner/lib/cli.py Outdated

@ansibot ansibot removed the support:core label Mar 1, 2019

@@ -0,0 +1,2 @@
unsupported

This comment has been minimized.

@mattclay

mattclay Mar 1, 2019

Member

The test can be supported if you update the runme.sh to run a playbook that creates an EC2 instance with the SSM Agent installed and then write out an inventory file for the rest of the test to use.

This comment has been minimized.

@gau1991

gau1991 Mar 1, 2019

Author

Ok got it, will add support for that.

Currently I added unsupported flag as the standerd connection test are failing for SSM Connection plugin because of unicode characters. We are in process to fix the plugin so that it will support all the unicode characters.

This comment has been minimized.

@gau1991

gau1991 Mar 18, 2019

Author

Hi @mattclay,
We updated runme.sh which will create Linux and Windows EC2 Instaces with SSM Agent Installed, and create inventory file as well for integration test cases execution.

Can you please review the code?

This comment has been minimized.

@mattclay

mattclay Mar 20, 2019

Member

Have the unicode issues been fixed? If so, remove the unsupported alias so the tests will run in CI.

If not, is there an issue or PR for fixing the issues that you can link to?

This comment has been minimized.

@mattclay

mattclay Mar 20, 2019

Member

You'll also need to add shippable/aws/group1 to the aliases when removing unsupported.

This comment has been minimized.

@gau1991

gau1991 Mar 20, 2019

Author

Sure. @mattclay . We already did this change in the PR #49652 . So closing this PR, as all the integration tests releated changes are cherry-picked.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 13, 2019

@gau1991 this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 14, 2019

@gau1991 this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 14, 2019

@gau1991 This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 commits.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

gau1991 and others added some commits Feb 28, 2019

krishnanandchoudhary and others added some commits Mar 12, 2019

@gau1991 gau1991 force-pushed the Flux7Labs:aws_ssm-connection-plugin-integration-test branch from 78614eb to 9155c52 Mar 14, 2019

@ansibot ansibot removed the merge_commit label Mar 14, 2019

gau1991 added some commits Mar 15, 2019

@mattclay

This comment has been minimized.

Copy link
Member

mattclay commented Mar 20, 2019

These tests should be in the same PR as the connection plugin since it hasn't been merged yet.

@gau1991 gau1991 closed this Mar 20, 2019

@sivel sivel removed the needs_triage label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.