Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WiP] Update the win_find module #53148

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@it-praktyk
Copy link
Contributor

it-praktyk commented Feb 28, 2019

SUMMARY

This update supersedes the pull request #43269 by @crossan007 and updates the win_find module in other areas too.

Summary of changes - the list will be updated

  • added parameters:
    • contains_patterns
    • contains_use_regex
  • corrects issues reported by PSScriptAnalyzer
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

win_find

ADDITIONAL INFORMATION

Fixes will be added soon

Corresponding bug of the find module

@it-praktyk

This comment has been minimized.

Copy link
Contributor Author

it-praktyk commented Feb 28, 2019

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Feb 28, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/windows/win_find.py:0:0: E309 version_added for new option (contains_patterns) should be '2.8'. Currently StrictVersion ('2.9')
lib/ansible/modules/windows/win_find.py:0:0: E309 version_added for new option (contains_use_regex) should be '2.8'. Currently StrictVersion ('2.9')

click here for bot help

@mattclay

This comment has been minimized.

Copy link
Member

mattclay commented Feb 28, 2019

@ansibot ansibot removed the needs_triage label Mar 1, 2019

@ansibot ansibot added the stale_ci label Mar 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.