Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] - New module aci_interface_policy_cdp #53180

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
5 participants
@tknipper11
Copy link

tknipper11 commented Mar 1, 2019

SUMMARY

Todo:

  • documentation
  • integration test
  • variable cleanup

New module will create and delete CDP policies within ACI.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

aci_interface_policy_cdp

cdp module create
- to do:
- documentation
- integration test
- variable cleanup
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 1, 2019

@tknipper11, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 1, 2019

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:76:38: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:130:0: missing-final-newline Final newline missing
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:130:0: mixed-line-endings Mixed line endings LF and CRLF

The test ansible-test sanity --test docs-build [explain] failed with 2 errors:

docs/docsite/rst/modules/list_of_all_modules.rst:46:0: undefined-label: undefined label: aci_interface_policy_cdp_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_network_modules.rst:63:0: undefined-label: undefined label: aci_interface_policy_cdp_module (if the link has no caption the label must precede a section header)

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:71:1: E115 expected an indented block (comment)
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:76:39: W291 trailing whitespace
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:88:5: E265 block comment should start with '# '
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:98:5: E303 too many blank lines (2)
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:130:11: W292 no newline at end of file

The test ansible-test sanity --test validate-modules [explain] failed with 46 errors:

lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E305 DOCUMENTATION.module: not a valid value for dictionary value @ data['module']. Got 'my_sample_module'
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E307 version_added should be '2.8'. Currently '2.4'
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E319 RETURN.message.returned: required key not provided @ data['message']['returned']. Got None
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E319 RETURN.message.type: required key not provided @ data['message']['type']. Got None
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E319 RETURN.original_message.returned: required key not provided @ data['original_message']['returned']. Got None
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'cdp_enabled' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'cdp_interface' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'cdp_policy' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'cert_key' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'cert_name' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'certificate_name' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'descr' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'description' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'host' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'hostname' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'output_level' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'port' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'private_key' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'state' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'timeout' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'use_proxy' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'use_ssl' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'user' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'username' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E322 Argument 'validate_certs' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E323 Argument 'ad_user' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E323 Argument 'adfs_authority_url' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E323 Argument 'api_profile' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E323 Argument 'auth_source' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E323 Argument 'cert_validation_mode' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E323 Argument 'client_id' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E323 Argument 'cloud_environment' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E323 Argument 'new' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E323 Argument 'profile' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E323 Argument 'secret' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E323 Argument 'subscription_id' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E323 Argument 'tenant' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E324 Argument 'output_level' in argument_spec defines default as ('normal') but documentation defines default as (None)
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E324 Argument 'state' in argument_spec defines default as ('present') but documentation defines default as (None)
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E324 Argument 'timeout' in argument_spec defines default as (30) but documentation defines default as (None)
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E324 Argument 'use_proxy' in argument_spec defines default as (True) but documentation defines default as (False)
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E324 Argument 'use_ssl' in argument_spec defines default as (True) but documentation defines default as (False)
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E324 Argument 'username' in argument_spec defines default as ('admin') but documentation defines default as (None)
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E324 Argument 'validate_certs' in argument_spec defines default as (True) but documentation defines default as (False)
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E326 Argument 'output_level' in argument_spec defines choices as (['debug', 'info', 'normal']) but documentation defines choices as ([])
lib/ansible/modules/network/aci/aci_interface_policy_cdp.py:0:0: E326 Argument 'state' in argument_spec defines choices as (['absent', 'present', 'query']) but documentation defines choices as ([])

click here for bot help

@kbreit

This comment has been minimized.

Copy link
Contributor

kbreit commented Mar 1, 2019

@dagwieers I am working with @tknipper11 on this

@mattclay mattclay added the ci_verified label Mar 2, 2019

@ansibot ansibot removed the needs_triage label Mar 2, 2019

@dagwieers dagwieers added the cisco label Mar 4, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 12, 2019

@ansibot ansibot added the stale_ci label Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.