Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding deployment facts #53204

Merged
merged 14 commits into from Mar 19, 2019

Conversation

Projects
None yet
3 participants
@zikalino
Copy link
Contributor

zikalino commented Mar 2, 2019

SUMMARY

Adding deployment facts module.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_deployment_facts

ADDITIONAL INFORMATION

zikalino added some commits Mar 2, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 2, 2019

The test ansible-test sanity --test pep8 [explain] failed with 11 errors:

lib/ansible/modules/cloud/azure/azure_rm_deployment_facts.py:145:13: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_deployment_facts.py:146:13: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_deployment_facts.py:147:13: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_deployment_facts.py:148:13: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_deployment_facts.py:149:13: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_deployment_facts.py:150:13: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_deployment_facts.py:151:13: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_deployment_facts.py:152:13: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_deployment_facts.py:153:13: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_deployment_facts.py:154:13: E265 block comment should start with '# '
lib/ansible/modules/cloud/azure/azure_rm_deployment_facts.py:155:13: E265 block comment should start with '# '

click here for bot help

@ansibot

This comment has been minimized.

zikalino added some commits Mar 2, 2019

zikalino added some commits Mar 18, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 18, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_deployment_facts.py:149:50: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_deployment_facts.py:149:51: W291 trailing whitespace

click here for bot help

zikalino added some commits Mar 18, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 18, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/cloud/azure/azure_rm_deployment_facts.py:212:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/cloud/azure/azure_rm_deployment_facts.py:228:50: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/azure/azure_rm_deployment_facts.py:212:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/azure/azure_rm_deployment_facts.py:228:51: W291 trailing whitespace

click here for bot help

zikalino added some commits Mar 18, 2019

@zikalino zikalino changed the title [WIP] adding deployment facts adding deployment facts Mar 18, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 18, 2019

@Madhura-CSI @brusMX @caohai @devigned @gustavomcarmo @haroldwongms @iphilpot @julienstroheker @lmazuel @obsoleted @sozercan @trstringer @tstringer @xscript @yaweiw @yuwzho

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review and removed WIP labels Mar 18, 2019


RETURN = '''
deployments:
description: A list of dictionaries containing facts for Artifact.

This comment has been minimized.

@yungezz

yungezz Mar 18, 2019

Contributor

not aligned description

type: str
sample: "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxxx/resourceGroups/myResourceGroup/providers/Microsoft.Network/networkI
nterfaces/myNetworkInterface"
name:

This comment has been minimized.

@yungezz

yungezz Mar 18, 2019

Contributor

is the name and type redundant? if not, then resource group should also been added.

This comment has been minimized.

@zikalino

zikalino Mar 18, 2019

Author Contributor

it's just coming from the api, so I have added it. maybe it's not necessary at all.
anyway, the resource group will be the same as deployment resource group.
I believe no ARM deployment creates resources outside it's resource group.

@ansibot ansibot removed the needs_triage label Mar 18, 2019

@yungezz

This comment has been minimized.

Copy link
Contributor

yungezz commented Mar 19, 2019

shipit

@ansibot ansibot added shipit and removed community_review labels Mar 19, 2019

@zikalino zikalino merged commit 41be785 into ansible:devel Mar 19, 2019

1 check passed

Shippable Run 114603 status is SUCCESS.
Details

@zikalino zikalino deleted the VSChina:deployment-facts branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.