Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netbox interface.py #53212

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@FragmentedPacket
Copy link
Contributor

FragmentedPacket commented Mar 2, 2019

SUMMARY

Adds a Netbox module to create/delete interfaces

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

netbox_interface.py

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 2, 2019

@FragmentedPacket this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment was marked as resolved.

Copy link
Contributor

ansibot commented Mar 2, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:288:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/net_tools/netbox/netbox_interface.py:230:29: undefined-variable Undefined variable 'missing_required_lib'
lib/ansible/modules/net_tools/netbox/netbox_interface.py:323:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:170:25: SyntaxError: "interface": {"name", "device"},

The test ansible-test sanity --test import --python 2.6 [explain] failed with 4 errors:

lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:170:25: SyntaxError: invalid syntax
lib/ansible/modules/net_tools/netbox/netbox_device.py:178:0: SyntaxError: invalid syntax (netbox_utils.py, line 170)
lib/ansible/modules/net_tools/netbox/netbox_interface.py:201:0: SyntaxError: invalid syntax (netbox_utils.py, line 170)
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:226:0: SyntaxError: invalid syntax (netbox_utils.py, line 170)

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/net_tools/netbox/netbox_interface.py:211:0: AttributeError: module 'traceback' has no attribute 'format_exec'

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/net_tools/netbox/netbox_interface.py:211:0: AttributeError: 'module' object has no attribute 'format_exec'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/net_tools/netbox/netbox_interface.py:211:0: AttributeError: module 'traceback' has no attribute 'format_exec'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/net_tools/netbox/netbox_interface.py:211:0: AttributeError: module 'traceback' has no attribute 'format_exec'

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/net_tools/netbox/netbox_interface.py:211:0: AttributeError: module 'traceback' has no attribute 'format_exec'

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:288:1: W391 blank line at end of file
lib/ansible/modules/net_tools/netbox/netbox_interface.py:323:1: W391 blank line at end of file

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/net_tools/netbox/netbox_interface.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'module 'traceback' has no attribute 'format_exec''
lib/ansible/modules/net_tools/netbox/netbox_interface.py:322:0: E109 Next to last line should be: if __name__ == "__main__":

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 2, 2019

@ansibot

This comment was marked as resolved.

Copy link
Contributor

ansibot commented Mar 2, 2019

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:170:25: SyntaxError: "interface": {"name", "device"},

The test ansible-test sanity --test import --python 2.6 [explain] failed with 4 errors:

lib/ansible/module_utils/net_tools/netbox/netbox_utils.py:170:25: SyntaxError: invalid syntax
lib/ansible/modules/net_tools/netbox/netbox_device.py:178:0: SyntaxError: invalid syntax (netbox_utils.py, line 170)
lib/ansible/modules/net_tools/netbox/netbox_interface.py:196:0: SyntaxError: invalid syntax (netbox_utils.py, line 170)
lib/ansible/modules/net_tools/netbox/netbox_ip_address.py:226:0: SyntaxError: invalid syntax (netbox_utils.py, line 170)

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/net_tools/netbox/netbox_interface.py:206:0: AttributeError: 'module' object has no attribute 'format_exec'

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/net_tools/netbox/netbox_interface.py:206:0: AttributeError: module 'traceback' has no attribute 'format_exec'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/net_tools/netbox/netbox_interface.py:206:0: AttributeError: module 'traceback' has no attribute 'format_exec'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/net_tools/netbox/netbox_interface.py:206:0: AttributeError: module 'traceback' has no attribute 'format_exec'

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/net_tools/netbox/netbox_interface.py:206:0: AttributeError: module 'traceback' has no attribute 'format_exec'

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/net_tools/netbox/netbox_interface.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'module 'traceback' has no attribute 'format_exec''

click here for bot help

@FragmentedPacket FragmentedPacket force-pushed the FragmentedPacket:netbox_interface.py branch from 9d46f19 to 3656ee2 Mar 2, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 2, 2019

@Anthony25 @amb1s1 @FragmentedPacket

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@smolz

This comment has been minimized.

Copy link
Contributor

smolz commented Mar 3, 2019

Tested and working for me on Ansible 2.8.0.dev0 and latest version of Netbox

@ansibot ansibot removed the needs_triage label Mar 4, 2019

@NilashishC
Copy link
Contributor

NilashishC left a comment

@FragmentedPacket Could you please add some unit tests for this new module?

@ansibot ansibot added the stale_ci label Mar 14, 2019

@ansibot ansibot removed the stale_ci label Mar 18, 2019

validate_certs=dict(type="bool", default=True)
)

global module

This comment has been minimized.

@NilashishC

NilashishC Mar 25, 2019

Contributor

Please refrain from using global.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.