Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: set product information to VM #53321

Open
wants to merge 20 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@ckurdekar
Copy link

ckurdekar commented Mar 5, 2019

PR to set the Product Information and ovf transport mode to the VM.

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_guest

ADDITIONAL INFORMATION

Modified vmware_guest to set product information and to set ovf transport mode


ckurdekar

@ckurdekar ckurdekar changed the base branch from devel to stable-2.7 Mar 5, 2019

@gundalow

This comment has been minimized.

Copy link
Contributor

gundalow commented Mar 5, 2019

@ckurdekar Hi, PRs should be made against the devel branch.
Once code is merged we create backport PRs for bug fixes only into the stable-2.x branch

ckurdekar

@ckurdekar ckurdekar changed the base branch from stable-2.7 to devel Mar 5, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 5, 2019

@ckurdekar This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.
  • More than 50 commits.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibot

This comment has been minimized.

@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Mar 5, 2019

@ckurdekar Thanks for the PR.

@Akasurde Akasurde changed the title PR - Added functions to set product information to the VM and to set … VMware: set product information to VM Mar 5, 2019

@mattclay

This comment has been minimized.

Copy link
Member

mattclay commented Mar 6, 2019

Closing and re-opening to update CI.

@mattclay mattclay closed this Mar 6, 2019

@mattclay mattclay reopened this Mar 6, 2019

@mattclay mattclay added the ci_verified label Mar 6, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 6, 2019

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/cloud/vmware/vmware_guest.py:1522:27: bad-whitespace Exactly one space required after assignment              vmconfig_spec =  self.configspec.vAppConfig if self.configspec.vAppConfig else new_vmconfig_spec                            ^
lib/ansible/modules/cloud/vmware/vmware_guest.py:1530:45: trailing-whitespace Trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest.py:1537:22: bad-whitespace Exactly one space required after assignment         vmconfig_spec =  self.configspec.vAppConfig if self.configspec.vAppConfig else orig_spec                       ^

The test ansible-test sanity --test pep8 [explain] failed with 16 errors:

lib/ansible/modules/cloud/vmware/vmware_guest.py:1520:14: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1520:14: E117 over-indented
lib/ansible/modules/cloud/vmware/vmware_guest.py:1521:14: E114 indentation is not a multiple of four (comment)
lib/ansible/modules/cloud/vmware/vmware_guest.py:1521:14: E265 block comment should start with '# '
lib/ansible/modules/cloud/vmware/vmware_guest.py:1522:14: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1522:29: E222 multiple spaces after operator
lib/ansible/modules/cloud/vmware/vmware_guest.py:1523:14: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1524:14: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1525:14: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1530:46: W291 trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest.py:1537:24: E222 multiple spaces after operator
lib/ansible/modules/cloud/vmware/vmware_guest.py:1554:17: E265 block comment should start with '# '
lib/ansible/modules/cloud/vmware/vmware_guest.py:1560:28: E114 indentation is not a multiple of four (comment)
lib/ansible/modules/cloud/vmware/vmware_guest.py:1561:28: E114 indentation is not a multiple of four (comment)
lib/ansible/modules/cloud/vmware/vmware_guest.py:1562:28: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1569:42: E128 continuation line under-indented for visual indent

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/vmware/vmware_guest.py:0:0: E309 version_added for new option (vapp_ovf_environment_transport) should be '2.8'. Currently StrictVersion ('2.7.8')
lib/ansible/modules/cloud/vmware/vmware_guest.py:0:0: E309 version_added for new option (vapp_product) should be '2.8'. Currently StrictVersion ('2.7.8')

click here for bot help

@ansibot ansibot removed the ci_verified label Mar 11, 2019

@ckurdekar

This comment has been minimized.

Copy link
Author

ckurdekar commented Mar 11, 2019

@mattclay @Akasurde Can you help me to understand failure cause for https://app.shippable.com/github/ansible/ansible/runs/113025/108/tests... have introduced 2 new properties, one is setting default value of transport mode if not provided and another is optional to set Product Information to VM if provided. Is setting default transport mode causing this failure

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 12, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/cloud/vmware/vmware_guest.py:1516:4: no-self-argument Method should have "self" as first argument
lib/ansible/modules/cloud/vmware/vmware_guest.py:1542:19: undefined-variable Undefined variable 'areEqual'

click here for bot help

ckurdekar added some commits Mar 12, 2019

ckurdekar
ckurdekar
ckurdekar

ckurdekar added some commits Mar 14, 2019

@ansibot ansibot removed the ci_verified label Mar 14, 2019

ckurdekar
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 14, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/vmware/vmware_guest.py:2424:9: E265 block comment should start with '# '
lib/ansible/modules/cloud/vmware/vmware_guest.py:2425:9: E265 block comment should start with '# '

click here for bot help

@ansibot ansibot added the ci_verified label Mar 14, 2019

ckurdekar
ckurdekar

ckurdekar added some commits Mar 14, 2019

ckurdekar
ckurdekar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.