Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RabbitMQ: Add parameter types #53328

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@dagwieers
Copy link
Member

dagwieers commented Mar 5, 2019

SUMMARY

This PR includes;

  • Add parameter types
  • Fixed one type from 'str' to 'list'
  • Clean up EXAMPLES
  • Added seealso sections
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

rabbitmq modules

@dagwieers dagwieers requested review from gundalow and acozine Mar 5, 2019

@dagwieers dagwieers force-pushed the dagwieers:rabbitmq-types branch from 3ff2e3c to 2edc8e4 Mar 5, 2019

@ansibot

This comment has been minimized.

RabbitMQ: Add parameter types
This PR includes;
- Add parameter types
- Fixed one type from 'str' to 'list'
- Clean up EXAMPLES
- Added seealso sections
- Fix sanity tests

@dagwieers dagwieers force-pushed the dagwieers:rabbitmq-types branch from a2a34fc to a7cb303 Mar 5, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 5, 2019

@bcoca bcoca removed the needs_triage label Mar 5, 2019

@mattclay

This comment was marked as resolved.

Copy link
Member

mattclay commented Mar 6, 2019

@mattclay mattclay added the ci_verified label Mar 6, 2019

@dagwieers

This comment was marked as resolved.

Copy link
Member Author

dagwieers commented Mar 6, 2019

It seems the included classes do not support something the module expects. It is unrelated to my changes IMO.

@ansibot ansibot added the core_review label Mar 11, 2019

@ansibot ansibot added the stale_ci label Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.