Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify port would remove and re-add ports on a modify which can results in an error #53341

Merged
merged 7 commits into from Mar 19, 2019

Conversation

Projects
None yet
6 participants
@carchi8py
Copy link
Contributor

carchi8py commented Mar 5, 2019

SUMMARY

During a modify on na_ontap_net_ifgrp, port would be removed and then re-added to the ifgrp. If the ifgrp is referenced by a vlan the last port can't be removed resulting in an error. This fix prevents ports from being removed and added back to an ifgrp. We only remove or add port if they are changed.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • na_ontap_net_ifgrp.py
ADDITIONAL INFORMATION

@carchi8py carchi8py changed the title Modify port would remove and readd ports on a modify which can results in an error Modify port would remove and re-add ports on a modify which can results in an error Mar 5, 2019

@ansibot

This comment has been minimized.

@lonico

lonico approved these changes Mar 5, 2019

Copy link
Contributor

lonico left a comment

shipit

@bcoca bcoca removed the needs_triage label Mar 5, 2019

@ansibot ansibot added shipit and removed core_review labels Mar 5, 2019

@JohnLieske
Copy link

JohnLieske left a comment

Looks good, tests are good.

@JohnLieske
Copy link

JohnLieske left a comment

Screenshot from 2019-03-18 11-22-50

GTG; files look good; tests look good

@gundalow gundalow merged commit 3ff2043 into ansible:devel Mar 19, 2019

1 check passed

Shippable Run 114456 status is SUCCESS.
Details
@gundalow

This comment has been minimized.

Copy link
Contributor

gundalow commented Mar 19, 2019

Thanks, merged!

catcombo added a commit to catcombo/ansible that referenced this pull request Mar 21, 2019

Modify port would remove and re-add ports on a modify which can resul…
…ts in an error (ansible#53341)

* Revert "changes to clusteR"

This reverts commit 33ee1b7.

* Revert "changes to clusteR"

This reverts commit 33ee1b7.

* Revert "Revert "changes to clusteR""

This reverts commit f1104a3.

* Revert "Revert "changes to clusteR""

This reverts commit f1104a3.

* documentation changes

* Revert "documentation changes"

This reverts commit 02c369d.

* Issue with port being removed and added on modify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.