Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP deprecations #53355

Open
wants to merge 14 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@rambleraptor
Copy link
Contributor

rambleraptor commented Mar 5, 2019

SUMMARY

Deprecating more GCP modules.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@@ -228,7 +228,13 @@ The following modules will be removed in Ansible 2.12. Please update your playbo
* ``katello`` use <https://github.com/theforeman/foreman-ansible-modules> instead.
* ``github_hooks`` use :ref:`github_webhook <github_webhook_module>` and :ref:`github_webhook_facts <github_webhook_facts_module>` instead.
* ``digital_ocean`` use :ref `digital_ocean_droplet <digital_ocean_droplet_module>` instead.
* ``gce`` use :ref `gce_compute_instance <gce_compute_instance_module>` instead.
* ``gce`` use :ref `gcp_compute_instance <gcp_compute_instance_module>` instead.

This comment has been minimized.

@rambleraptor

rambleraptor Mar 5, 2019

Author Contributor

This was referencing a module that does not exist.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 5, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 23 errors:

lib/ansible/modules/cloud/google/_gcp_forwarding_rule.py:0:0: E322 Argument 'credentials_file' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/google/_gcp_forwarding_rule.py:0:0: E322 Argument 'load_balancing_scheme' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/google/_gcp_forwarding_rule.py:0:0: E322 Argument 'pem_file' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/google/_gcp_forwarding_rule.py:0:0: E322 Argument 'project_id' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/google/_gcp_forwarding_rule.py:0:0: E322 Argument 'service_account_email' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/google/_gcp_forwarding_rule.py:0:0: E322 Argument 'service_account_permissions' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/google/_gcp_forwarding_rule.py:0:0: E324 Argument 'load_balancing_scheme' in argument_spec defines default as ('EXTERNAL') but documentation defines default as (None)
lib/ansible/modules/cloud/google/_gcp_forwarding_rule.py:0:0: E324 Argument 'protocol' in argument_spec defines default as ('TCP') but documentation defines default as (None)
lib/ansible/modules/cloud/google/_gcp_forwarding_rule.py:0:0: E326 Argument 'load_balancing_scheme' in argument_spec defines choices as (['EXTERNAL']) but documentation defines choices as ([])
lib/ansible/modules/cloud/google/_gcp_forwarding_rule.py:0:0: E326 Argument 'protocol' in argument_spec defines choices as (['TCP']) but documentation defines choices as ([])
lib/ansible/modules/cloud/google/_gcp_healthcheck.py:0:0: E324 Argument 'state' in argument_spec defines default as ('present') but documentation defines default as (None)
lib/ansible/modules/cloud/google/_gcp_healthcheck.py:0:0: E326 Argument 'service_account_permissions' in argument_spec defines choices as ([]) but documentation defines choices as ([['bigquery'], ['cloud-platform'], ['compute-ro'], ['compute-rw'], ['useraccounts-ro'], ['useraccounts-rw'], ['datastore'], ['logging-write'], ['monitoring'], ['sql-admin'], ['storage-full'], ['storage-ro'], ['storage-rw'], ['taskqueue'], ['userinfo-email']])
lib/ansible/modules/cloud/google/_gcp_url_map.py:0:0: E322 Argument 'credentials_file' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/google/_gcp_url_map.py:0:0: E322 Argument 'pem_file' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/google/_gcp_url_map.py:0:0: E322 Argument 'project_id' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/google/_gcp_url_map.py:0:0: E322 Argument 'service_account_email' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/google/_gcp_url_map.py:0:0: E322 Argument 'service_account_permissions' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/google/_gcp_url_map.py:0:0: E322 Argument 'state' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/google/_gcp_url_map.py:0:0: E324 Argument 'state' in argument_spec defines default as ('present') but documentation defines default as (None)
lib/ansible/modules/cloud/google/_gcp_url_map.py:0:0: E326 Argument 'state' in argument_spec defines choices as (['absent', 'present']) but documentation defines choices as ([])
lib/ansible/modules/cloud/google/_gcspanner.py:0:0: E322 Argument 'credentials_file' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/google/_gcspanner.py:0:0: E322 Argument 'project_id' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/google/_gcspanner.py:0:0: E322 Argument 'service_account_email' is listed in the argument_spec, but not documented in the module documentation

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 5, 2019

rambleraptor added some commits Mar 5, 2019

@ansibot ansibot added the stale_ci label Mar 5, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 5, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/cloud/google/_gcp_backend_service.py:0:0: E305 DOCUMENTATION.deprecated: required key not provided @ data['deprecated']. Got None
lib/ansible/modules/cloud/google/_gcp_backend_service.py:0:0: E318 Module deprecation/removed must agree in Metadata, by prepending filename with "_", and setting DOCUMENTATION.deprecated for deprecation or by removing all documentation for removed
lib/ansible/modules/cloud/google/_gcp_target_proxy.py:0:0: E305 DOCUMENTATION.deprecated: required key not provided @ data['deprecated']. Got None
lib/ansible/modules/cloud/google/_gcp_target_proxy.py:0:0: E318 Module deprecation/removed must agree in Metadata, by prepending filename with "_", and setting DOCUMENTATION.deprecated for deprecation or by removing all documentation for removed

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Mar 5, 2019

rambleraptor added some commits Mar 5, 2019

@ansibot ansibot added core_review and removed needs_revision labels Mar 6, 2019

@rambleraptor

This comment has been minimized.

Copy link
Contributor Author

rambleraptor commented Mar 6, 2019

ptal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.