Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warning message "Ran out of time waiting for sg-xxx" #53374

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@BitPan
Copy link

BitPan commented Mar 6, 2019

SUMMARY

Fix issue #42661 - ec2_group "Ran out of time waiting for sg-xxx IpPermissions" if protocol set to numeric value

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_group module

ADDITIONAL INFORMATION

The current ec2_group module throws a warning message "Ran out of time waiting for sg-xxx IpPermissions..." when it performs any update on an existing security group.

I believe this error is because wait_for_rule_propagation() function is comparing the current security group state with incorrect desired state.

The list named_tuple_ingress_list and named_tuple_egress_list was supposed to represent the desired ingress and egress security group permissions, but they got modified in function update_rule_descriptions()

Deep copy the origin list named_tuple_ingress_list and named_tuple_egress_list to new variable desired_ingress and desird_egress to help maintain the desired ingress & egress security group permissions.

# named_tuple_ingress_list and named_tuple_egress_list do not 
# represents the desired security group permissions that user wants
security_group = wait_for_rule_propagation(module, group, named_tuple_ingress_list, named_tuple_egress_list, purge_rules, purge_rules_egress)
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 6, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 6, 2019

@BitPan, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 6, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/ec2_group.py:1147:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/cloud/amazon/ec2_group.py:1153:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/ec2_group.py:1147:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/amazon/ec2_group.py:1153:1: W293 blank line contains whitespace

click here for bot help

@lathama

This comment has been minimized.

Copy link
Contributor

lathama commented Mar 12, 2019

Any chance you could squash your commits?

@BitPan BitPan force-pushed the BitPan:feature-fix-42661 branch from fec75e8 to 1e9fe1a Mar 12, 2019

@BitPan

This comment has been minimized.

Copy link
Author

BitPan commented Mar 12, 2019

Any chance you could squash your commits?

Done :)

@ansibot ansibot added the stale_ci label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.