Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derived aci_access_port_to_interface_policy_leaf_profile for fex port… #53394

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@LucRobalo
Copy link

LucRobalo commented Mar 6, 2019

… selector

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 6, 2019

@LucRobalo, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 6, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/network/aci/aci_access_port_to_fex_interface_policy_leaf_profile.py:355:0: missing-final-newline Final newline missing
lib/ansible/modules/network/aci/aci_access_port_to_fex_interface_policy_leaf_profile.py:355:0: mixed-line-endings Mixed line endings LF and CRLF

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/aci/aci_access_port_to_fex_interface_policy_leaf_profile.py:355:11: W292 no newline at end of file

The test ansible-test sanity --test validate-modules [explain] failed with 7 errors:

lib/ansible/modules/network/aci/aci_access_port_to_fex_interface_policy_leaf_profile.py:0:0: E307 version_added should be '2.8'. Currently '2.5'
lib/ansible/modules/network/aci/aci_access_port_to_fex_interface_policy_leaf_profile.py:0:0: E319 RETURN.filter_string.type: not a valid value for dictionary value @ data['filter_string']['type']. Got 'string'
lib/ansible/modules/network/aci/aci_access_port_to_fex_interface_policy_leaf_profile.py:0:0: E319 RETURN.method.type: not a valid value for dictionary value @ data['method']['type']. Got 'string'
lib/ansible/modules/network/aci/aci_access_port_to_fex_interface_policy_leaf_profile.py:0:0: E319 RETURN.raw.type: not a valid value for dictionary value @ data['raw']['type']. Got 'string'
lib/ansible/modules/network/aci/aci_access_port_to_fex_interface_policy_leaf_profile.py:0:0: E319 RETURN.response.type: not a valid value for dictionary value @ data['response']['type']. Got 'string'
lib/ansible/modules/network/aci/aci_access_port_to_fex_interface_policy_leaf_profile.py:0:0: E319 RETURN.url.type: not a valid value for dictionary value @ data['url']['type']. Got 'string'
lib/ansible/modules/network/aci/aci_access_port_to_fex_interface_policy_leaf_profile.py:0:0: E326 Argument 'interface_type' in argument_spec defines choices as (['fex', 'port_channel', 'switch_port', 'vpc']) but documentation defines choices as (['port_channel', 'switch_port', 'vpc'])

click here for bot help

@smnmtzgr

This comment has been minimized.

Copy link
Contributor

smnmtzgr commented Mar 6, 2019

@LucRobalo Can you describe why we need a new module here? interface_type "fex" is already available with aci_access_port_to_interface_policy_leaf_profile

@LucRobalo

This comment has been minimized.

Copy link
Author

LucRobalo commented Mar 6, 2019

@ansibot ansibot added the stale_ci label Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.