Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate botmeta teams #53415

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from
Open

Conversation

@gundalow
Copy link
Contributor

@gundalow gundalow commented Mar 6, 2019

SUMMARY

I've seen twice recently undefined $team_ entries (missing or typos). This causes Ansibulbot to get into a crash loop.

Ensure that any mentioned $team_ maintainers listed under files: have been defined in macros:

ansible-test sanity --python 3.5 --test botmeta
Sanity check using botmeta
ERROR: Found 9 botmeta issue(s) which need to be resolved:
ERROR: .github/BOTMETA.yml:0:0: Entry '$module_utils/csharp' references unknown team '$team_windows_core'
ERROR: .github/BOTMETA.yml:0:0: Entry '$module_utils/powershell' references unknown team '$team_windows_core'
ERROR: .github/BOTMETA.yml:0:0: Entry '$modules/cloud/amazon/ec2.py' references unknown team '$team_ansibleAS'
ERROR: .github/BOTMETA.yml:0:0: Entry '$modules/windows/' references unknown team '$team_windows'
ERROR: .github/BOTMETA.yml:0:0: Entry '$plugins/action/win' references unknown team '$team_windows_core'
ERROR: .github/BOTMETA.yml:0:0: Entry '$plugins/connection/psrp.py' references unknown team '$team_windows_core'
ERROR: .github/BOTMETA.yml:0:0: Entry '$plugins/connection/winrm.py' references unknown team '$team_windows_core'
ERROR: .github/BOTMETA.yml:0:0: Entry '$plugins/shell/powershell.py' references unknown team '$team_windows_core'
ERROR: .github/BOTMETA.yml:0:0: Entry 'lib/ansible/executor/powershell' references unknown team '$team_windows_core'
ERROR: The 1 sanity test(s) listed below (out of 1) failed. See error output above for details.
botmeta
ISSUE TYPE
  • Bugfix Pull Request
@sivel sivel self-requested a review Mar 6, 2019
@ansibot
Copy link
Contributor

@ansibot ansibot commented Mar 6, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

test/sanity/code-smell/botmeta.py:75:35: E226 missing whitespace around arithmetic operator
test/sanity/code-smell/botmeta.py:105:1: E302 expected 2 blank lines, found 1

click here for bot help

Loading

@ansibot
Copy link
Contributor

@ansibot ansibot commented Mar 6, 2019

Loading

test/sanity/code-smell/botmeta.py Outdated Show resolved Hide resolved
Loading
test/sanity/code-smell/botmeta.py Outdated Show resolved Hide resolved
Loading
test/sanity/code-smell/botmeta.py Outdated Show resolved Hide resolved
Loading
test/sanity/code-smell/botmeta.py Show resolved Hide resolved
Loading
@ansibot

This comment has been hidden.

@gundalow gundalow changed the title [WIP] Validate botmeta teams Validate botmeta teams Mar 8, 2019
@gundalow
Copy link
Contributor Author

@gundalow gundalow commented Apr 9, 2019

ci rerun

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants