Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ini_file: Add newline between sections #53447

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@bobkarreman
Copy link

bobkarreman commented Mar 7, 2019

SUMMARY

Fixes #29904 To add newline between sections in ini files

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ini_file

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 7, 2019

@bobkarreman bobkarreman force-pushed the bobkarreman:ini-file-newline branch from fdf61c3 to 2bb1f67 Mar 7, 2019

@Akasurde Akasurde changed the title Fixes #29904 Add newline between sections ini_file: Add newline between sections Mar 7, 2019

@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Mar 7, 2019

CI Failure -

01:12 task path: /private/var/root/.ansible/test/tmp/ini_file-Rk6W_C-ÅÑŚÌβŁÈ/test/integration/targets/ini_file/tasks/main.yml:42
01:12 ok: [testhost] => {
01:12     "ansible_facts": {
01:12         "content1": "\n[drinks]\nfav = lemonade\n\n", 
01:12         "expected1": "\n[drinks]\nfav = lemonade\n"
01:12     }, 
01:12     "changed": false
01:12 }
01:12 Read vars_file 'integration_config.yml'
01:12 
01:12 TASK [ini_file : Verify content of ini file is as expected] ********************
01:12 task path: /private/var/root/.ansible/test/tmp/ini_file-Rk6W_C-ÅÑŚÌβŁÈ/test/integration/targets/ini_file/tasks/main.yml:51
01:12 fatal: [testhost]: FAILED! => {
01:12     "assertion": "content1 == expected1", 
01:12     "changed": false, 
01:12     "evaluated_to": false, 
01:12     "msg": "Assertion failed"
01:12 }
01:12 Read vars_file 'integration_config.yml'
01:12 

in https://app.shippable.com/github/ansible/ansible/runs/112386/57/console

Could you please write integration test for this change ? Thanks.

needs_info

@ansibot ansibot added needs_info and removed needs_triage labels Mar 7, 2019

@bobkarreman bobkarreman force-pushed the bobkarreman:ini-file-newline branch from 2bb1f67 to 35cd836 Mar 7, 2019

@bobkarreman

This comment has been minimized.

Copy link
Author

bobkarreman commented Mar 7, 2019

@Akasurde I adjusted the existing integration test to work with the fix.

I had some troubles running them locally that's why I just made a PR (sorry) but now I managed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.