Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iptables: Added functionality for iptables-save (Resolves #25149) #53513

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
5 participants
@amolkahat
Copy link
Contributor

amolkahat commented Mar 8, 2019

Signed-off-by: Amol Kahat akahat@redhat.com

SUMMARY

Added tests for the iptables-save functionality

Resolves #25149

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • iptables
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 8, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 8, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/system/iptables.py:0:0: E326 Argument 'state' in argument_spec defines choices as (['absent', 'present', 'save']) but documentation defines choices as (['absent', 'present'])

click here for bot help

@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Mar 8, 2019

@amolkahat Thanks for the contribution. Could you please check CI failures and let me know ? Thanks.

needs_info

@ansibot ansibot added needs_info and removed needs_triage labels Mar 8, 2019

iptables: Added functionality for iptables-save (Resolves #25149)
Added tests for the iptables-save functionality

Signed-off-by: Amol Kahat <akahat@redhat.com>

@amolkahat amolkahat force-pushed the amolkahat:GH_25149 branch from 60e495e to b4c10cc Mar 11, 2019

@bluikko

This comment has been minimized.

Copy link

bluikko commented Mar 14, 2019

I appreciate this option, but it does not actually work for us (and probably many others).
We need to directly add the rules to the file because we have comments in this file. If the iptables-save command is run, the comments in the file are overwritten.

@LinusU

This comment has been minimized.

Copy link
Contributor

LinusU commented Mar 14, 2019

Seems a bit strange to highjack the state key for this? 🤔

Not sure how to best do it though, since to save or not is a global option, and every other invocation of iptables concerns a single line...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.