Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - meraki - Create assign_net_id() and assign_org_id() methods for code reuse #53585

Open
wants to merge 6 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@kbreit
Copy link
Contributor

kbreit commented Mar 9, 2019

SUMMARY
  • Methods will assign org_id or net_id information and look up if not there

Fixes #53586

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

meraki

kbreit added some commits Mar 9, 2019

Create assign_net_id() method
- Method will assign net_id information and look up if not there
- Formerly this was used in some Meraki modules
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 9, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 9, 2019

The test ansible-test sanity --test pylint [explain] failed with 7 errors:

lib/ansible/module_utils/network/meraki/meraki.py:231:0: mixed-indentation Found indentation with tabs instead of spaces
lib/ansible/module_utils/network/meraki/meraki.py:232:0: mixed-indentation Found indentation with tabs instead of spaces
lib/ansible/module_utils/network/meraki/meraki.py:233:0: mixed-indentation Found indentation with tabs instead of spaces
lib/ansible/module_utils/network/meraki/meraki.py:234:0: mixed-indentation Found indentation with tabs instead of spaces
lib/ansible/module_utils/network/meraki/meraki.py:235:0: mixed-indentation Found indentation with tabs instead of spaces
lib/ansible/modules/network/meraki/meraki_config_template.py:238:36: undefined-variable Undefined variable 'nets'
lib/ansible/modules/network/meraki/meraki_config_template.py:258:40: undefined-variable Undefined variable 'nets'

The test ansible-test sanity --test pep8 [explain] failed with 11 errors:

lib/ansible/module_utils/network/meraki/meraki.py:231:5: E101 indentation contains mixed spaces and tabs
lib/ansible/module_utils/network/meraki/meraki.py:231:5: W191 indentation contains tabs
lib/ansible/module_utils/network/meraki/meraki.py:232:5: E101 indentation contains mixed spaces and tabs
lib/ansible/module_utils/network/meraki/meraki.py:232:5: W191 indentation contains tabs
lib/ansible/module_utils/network/meraki/meraki.py:233:5: E101 indentation contains mixed spaces and tabs
lib/ansible/module_utils/network/meraki/meraki.py:233:5: W191 indentation contains tabs
lib/ansible/module_utils/network/meraki/meraki.py:234:5: E101 indentation contains mixed spaces and tabs
lib/ansible/module_utils/network/meraki/meraki.py:234:5: W191 indentation contains tabs
lib/ansible/module_utils/network/meraki/meraki.py:234:7: E117 over-indented
lib/ansible/module_utils/network/meraki/meraki.py:235:5: E101 indentation contains mixed spaces and tabs
lib/ansible/module_utils/network/meraki/meraki.py:235:5: W191 indentation contains tabs

click here for bot help

@ansibot ansibot added the ci_verified label Mar 9, 2019

Add optional nets parameter to asign_net_id
- There's a situation where nets is needed in module, so that's useful
- Convert to spaces

@ansibot ansibot removed the ci_verified label Mar 10, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 10, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/module_utils/network/meraki/meraki.py:236:17: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/network/meraki/meraki.py:236:18: W291 trailing whitespace

click here for bot help

@ansibot ansibot added the ci_verified label Mar 10, 2019

@ansibot ansibot removed the ci_verified label Mar 10, 2019

Create assign_org_id() method
- Method is org_id equivalent of assign_net_id()
- Implement assign_org_id() in modules

@kbreit kbreit changed the title [WIP] - meraki - Create assign_net_id() method for code reuse [WIP] - meraki - Create assign_net_id() and assign_org_id() methods for code reuse Mar 10, 2019

@ansibot ansibot added the test label Mar 10, 2019

@ansibot ansibot added the stale_ci label Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.