Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl_privatekey: add backup option #53593

Merged
merged 8 commits into from Mar 18, 2019

Update lib/ansible/modules/crypto/openssl_privatekey.py

Co-Authored-By: felixfontein <felix@fontein.de>
  • Loading branch information...
MarkusTeufelberger and felixfontein committed Mar 17, 2019
commit 93a5d1946601c9956694c5ad042310da2efb75b5
@@ -26,7 +26,7 @@
- "Please note that the module regenerates private keys if they don't match

This comment has been minimized.

Copy link
@MarkusTeufelberger

MarkusTeufelberger Mar 17, 2019

Contributor
Suggested change
- "Please note that the module regenerates private keys if they don't match
- "Take note that the module regenerates private keys if they don't match

This comment has been minimized.

Copy link
@felixfontein

felixfontein Mar 17, 2019

Author Contributor

What's wrong with "Please note"?

This comment has been minimized.

Copy link
@MarkusTeufelberger

MarkusTeufelberger Mar 17, 2019

Contributor

While I appreciate the courtesy, it raises the question if/where we should write "please" elsewhere and how often.

the module's options. In particular, if you provide another passphrase
(or specify none), change the keysize, etc., the private key will be
regenerated. If you are concerned of this overwriting your private key,
regenerated. If you are concerned that this could overwrite your private key,
please consider using the I(backup) option."
This conversation was marked as resolved by felixfontein

This comment has been minimized.

Copy link
@MarkusTeufelberger

MarkusTeufelberger Mar 17, 2019

Contributor
Suggested change
please consider using the I(backup) option."
consider using the I(backup) option."
- The module can use the cryptography Python library, or the pyOpenSSL Python
library. By default, it tries to detect which one is available. This can be
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.