Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] adding vng -- temporary pr, will be moved to another one #53622

Open
wants to merge 13 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@zikalino
Copy link
Contributor

zikalino commented Mar 11, 2019

SUMMARY
  • New Module Pull Request
COMPONENT NAME

azure_rm_virtualnetworkgateway

ADDITIONAL INFORMATION

original pr: #44411

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:335:20: undefined-variable Undefined variable 'fh'

The test ansible-test sanity --test validate-modules [explain] failed with 8 errors:

lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E307 version_added should be '2.8'. Currently '2.7'
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E322 Argument 'active_active' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E322 Argument 'gateway_default_site' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E322 Argument 'vpn_client_configuration' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E326 Argument 'gateway_type' in argument_spec defines choices as ([]) but documentation defines choices as (['Vpn', 'ExpressRoute'])
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E326 Argument 'sku' in argument_spec defines choices as ([]) but documentation defines choices as (['VpnGw1', 'VpnGw2', 'VpnGw3'])
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E326 Argument 'vpn_type' in argument_spec defines choices as ([]) but documentation defines choices as (['RouteBased', 'PolicyBased'])
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:167:21: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:167:21: error RETURN: syntax error: expected ',' or '}', but got '<scalar>'

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:288:20: undefined-variable Undefined variable 'fh'

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E324 Argument 'gateway_type' in argument_spec defines default as ('vpn') but documentation defines default as ('Vpn')
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E324 Argument 'sku' in argument_spec defines default as ('VpnGw1') but documentation defines default as ('vpn_gw1')
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E324 Argument 'vpn_type' in argument_spec defines default as ('RouteBased') but documentation defines default as ('route_based')
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E326 Argument 'sku' in argument_spec defines choices as ([]) but documentation defines choices as (['vpn_gw1', 'vpn_gw2', 'vpn_gw3'])
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E326 Argument 'vpn_type' in argument_spec defines choices as ([]) but documentation defines choices as (['route_based', 'policy_based'])

click here for bot help

@ansibot ansibot added the ci_verified label Mar 11, 2019

@ansibot ansibot removed the ci_verified label Mar 11, 2019

zikalino added some commits Mar 11, 2019

fix
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:358:35: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:358:36: W291 trailing whitespace

click here for bot help

@ansibot ansibot added the ci_verified label Mar 11, 2019

@ansibot ansibot removed the ci_verified label Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.