Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New AWS SES module to enable DKIM on an identity… #53637

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@stefanhorning
Copy link
Contributor

stefanhorning commented Mar 11, 2019

… and/or start DKIM verification process.

SUMMARY

New module aws_ses_identity_dkim for handling DKIM settings on an new or existing SES identity.

See https://docs.aws.amazon.com/ses/latest/DeveloperGuide/easy-dkim-setup-domain.html

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

aws_ses_identity_dkim

ADDITIONAL INFORMATION

For usage see module docs. This module complements other, already existing SES modules, like aws_ses_identity and aws_ses_policy.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

@stefanhorning, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:103:36: missing-format-argument-key Missing keyword argument 'domain' for format string
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:103:36: unused-format-string-argument Unused format argument 'identity'

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:115:13: E261 at least two spaces before inline comment
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:118:1: E302 expected 2 blank lines, found 1

The test ansible-test sanity --test validate-modules [explain] failed with 16 errors:

lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E319 RETURN.dkim_attributes.returned: required key not provided @ data['dkim_attributes']['returned']. Got None
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'access_key' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'access_token' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'aws_access_key' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'aws_region' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'aws_secret_key' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'ec2_access_key' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'ec2_region' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'ec2_secret_key' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'ec2_url' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'profile' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'region' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'secret_key' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'security_token' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'validate_certs' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E324 Argument 'validate_certs' in argument_spec defines default as (True) but documentation defines default as (False)

click here for bot help

@ansibot ansibot removed the ci_verified label Mar 11, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:115:13: E261 at least two spaces before inline comment
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:118:1: E302 expected 2 blank lines, found 1

The test ansible-test sanity --test validate-modules [explain] failed with 16 errors:

lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E319 RETURN.dkim_attributes.returned: required key not provided @ data['dkim_attributes']['returned']. Got None
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'access_key' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'access_token' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'aws_access_key' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'aws_region' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'aws_secret_key' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'ec2_access_key' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'ec2_region' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'ec2_secret_key' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'ec2_url' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'profile' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'region' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'secret_key' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'security_token' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E322 Argument 'validate_certs' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E324 Argument 'validate_certs' in argument_spec defines default as (True) but documentation defines default as (False)

click here for bot help

@ansibot ansibot added the ci_verified label Mar 11, 2019

@ansibot ansibot removed the ci_verified label Mar 11, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_ses_identity_dkim.py:0:0: E319 RETURN.dkim_attributes.returned: required key not provided @ data['dkim_attributes']['returned']. Got None

click here for bot help

@ansibot ansibot added the ci_verified label Mar 11, 2019

@ansibot ansibot removed the ci_verified label Mar 11, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

@Constantin007 @Constantin07 @Deepakkothandan @Etherdaemon @Java1Guy @Madhura-CSI @MichaelBaydoun @Sodki @Zeekin @adq @akazakov @alachaum @amir343 @anryko @bekelchik @brandond @captainkerk @chenl87 @defunctio @dennisconrad @dkhenry @fiunchinho @fivethreeo @flowerysong @garethr @gobins @gunzy83 @gurumaia @hsingh @hyperized @iiibrad @infectsoldier @j-carl @jarv @Java1Guy @jimbydamonk @jmenga @joelthompson @jonhadfield @jonmer85 @joshsouza @jsdalton @jsmartin @kaczynskid @leedm777 @linuxdynasty @loia @lwade @michaeljs1990 @minichate @mjschultz @mmochan @nand0p @naslanidis @nathanwebsterdotme @nerzhul @nickball @orthanc @ozbillwang @piontas @pjodouin @prasadkatti @psykotox @ptux @pwnall @raags @rafaeldriutti @rickmendes @roadmapper @rrey @ryansb @ryansydnor @scicoin-project @scottanderson42 @sdubrul @shepdelacreme @silviud @slapula @steynovich @tastychutney @tgerla @timmahoney @tombamford @tomislacker @tsiganenok @viper233 @whiter @willricardo @wilvk @wimnat @yaakov-github @zacblazic @zbal @zimbatm

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.