Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest updates from FTD Ansible downstream repository. #53638

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@119Vik
Copy link

119Vik commented Mar 11, 2019

SUMMARY

In the scope of this PR following improvement were implemented for FTD related modules

  • add a better implementation of the upsert operation;
  • add API version lookup functionality;
  • add a filter which removes duplicated references from the list of references, fixes issue.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins.httpapi.ftd
modules.network.ftd.ftd_configuration

119vik
Add latest updates from FTD Ansible downstream repository.
 - add a better implementation of the upsert operation;
 - add API version lookup functionality;
 - add filter which remove duplicated references from the list of references;
 - fix minor bugs.
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

@119Vik, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

The test ansible-test sanity --test import --python 2.6 [explain] failed with 2 errors:

lib/ansible/module_utils/network/ftd/common.py:21:0: ImportError: No module named ordereddict
test/runner/.tox/import/lib/ansible/module_utils/network/ftd/common.py:21:0: ImportError: No module named ordereddict

The test ansible-test sanity --test no-underscore-variable [explain] failed with 3 errors:

lib/ansible/module_utils/network/ftd/configuration.py:277:9: use `dummy` instead of `_` for a variable name
lib/ansible/module_utils/network/ftd/configuration.py:369:15: use `dummy` instead of `_` for a variable name
test/units/module_utils/network/ftd/test_fdm_swagger_with_real_data.py:61:17: use `dummy` instead of `_` for a variable name

click here for bot help

119vik
@kbreit

This comment has been minimized.

Copy link
Contributor

kbreit commented Mar 17, 2019

+label cisco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.