Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve netapp_e_storagepool and add unit and integration tests. #53639

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@ndswartz
Copy link
Contributor

ndswartz commented Mar 11, 2019

SUMMARY

Refactored module for better maintainability and cleaned up documentation for more clarity.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

netapp_e_storagepool

ADDITIONAL INFORMATION
ansible 2.8.0.dev0
  config file = None
  configured module search path = [u'/home/swartzn/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/swartzn/ansible-dev/lib/ansible
  executable location = /home/swartzn/ansible-dev/bin/ansible
  python version = 2.7.15rc1 (default, Nov 12 2018, 14:31:15) [GCC 7.3.0]
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:162:14: using-constant-test Using a conditional statement with a constant value

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:147:0: ImportError: cannot import name Counter

The test ansible-test sanity --test no-underscore-variable [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:780:25: use `dummy` instead of `_` for a variable name

The test ansible-test sanity --test pep8 [explain] failed with 63 errors:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:67:76: W291 trailing whitespace
lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:120:106: W291 trailing whitespace
lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:621:21: E117 over-indented
lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:722:17: E117 over-indented
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:19:161: E501 line too long (464 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:20:161: E501 line too long (555 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:21:161: E501 line too long (556 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:22:161: E501 line too long (556 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:23:161: E501 line too long (556 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:24:161: E501 line too long (556 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:25:161: E501 line too long (556 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:26:161: E501 line too long (556 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:27:161: E501 line too long (556 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:28:161: E501 line too long (556 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:29:161: E501 line too long (556 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:30:161: E501 line too long (556 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:31:161: E501 line too long (556 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:32:161: E501 line too long (556 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:33:161: E501 line too long (556 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:34:161: E501 line too long (556 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:35:161: E501 line too long (555 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:36:161: E501 line too long (555 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:37:161: E501 line too long (555 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:38:161: E501 line too long (555 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:39:161: E501 line too long (555 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:40:161: E501 line too long (555 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:41:161: E501 line too long (555 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:42:161: E501 line too long (555 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:43:161: E501 line too long (555 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:44:161: E501 line too long (555 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:45:161: E501 line too long (555 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:46:161: E501 line too long (555 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:47:161: E501 line too long (555 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:48:161: E501 line too long (556 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:50:161: E501 line too long (1036 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:51:161: E501 line too long (1082 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:52:161: E501 line too long (1126 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:53:161: E501 line too long (1170 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:54:161: E501 line too long (1214 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:55:161: E501 line too long (1280 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:57:161: E501 line too long (692 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:58:161: E501 line too long (301 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:59:161: E501 line too long (345 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:60:161: E501 line too long (389 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:61:161: E501 line too long (434 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:62:161: E501 line too long (478 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:63:161: E501 line too long (522 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:64:161: E501 line too long (566 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:65:161: E501 line too long (610 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:66:161: E501 line too long (654 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:67:161: E501 line too long (699 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:105:161: E501 line too long (720 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:132:161: E501 line too long (7595 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:141:161: E501 line too long (190 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:151:161: E501 line too long (1101 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:162:161: E501 line too long (536 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:183:161: E501 line too long (199 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:194:161: E501 line too long (194 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:207:161: E501 line too long (193 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:218:161: E501 line too long (194 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:233:161: E501 line too long (194 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:248:161: E501 line too long (194 > 160 characters)
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:263:161: E501 line too long (194 > 160 characters)

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: E305 DOCUMENTATION.options.secure_pool.description.2: expected str @ data['options']['secure_pool']['description'][2]. Got {'Warning': 'once security is enabled it is impossible to disable without erasing the drives.'}
lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: E309 version_added for new option (criteria_drive_require_da) should be '2.8'. Currently StrictVersion ('0.0')
lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: E319 RETURN.msg.type: not a valid value for dictionary value @ data['msg']['type']. Got 'string'
test/sanity/validate-modules/ignore.txt:813:1: A102 Remove since "lib/ansible/modules/storage/netapp/netapp_e_storagepool.py" passes "E322" test
test/sanity/validate-modules/ignore.txt:814:1: A102 Remove since "lib/ansible/modules/storage/netapp/netapp_e_storagepool.py" passes "E326" test

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Mar 11, 2019

@ndswartz ndswartz force-pushed the ndswartz:storagepool_dev_upstream branch 5 times, most recently from 1ea8431 to a833070 Mar 11, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:152:0: ImportError: No module named backport_collections

The test ansible-test sanity --test pep8 [explain] failed with 10 errors:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:67:76: W291 trailing whitespace
lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:121:106: W291 trailing whitespace
lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:627:21: E117 over-indented
lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:728:17: E117 over-indented
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:237:13: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:249:13: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:261:13: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:274:13: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:287:13: E121 continuation line under-indented for hanging indent
test/units/modules/storage/netapp/test_netapp_e_storagepool.py:301:13: E121 continuation line under-indented for hanging indent

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: E305 DOCUMENTATION.options.secure_pool.description.2: expected str @ data['options']['secure_pool']['description'][2]. Got {'Warning': 'once security is enabled it is impossible to disable without erasing the drives.'}

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

@ansibot ansibot added the test label Mar 11, 2019

@ndswartz ndswartz force-pushed the ndswartz:storagepool_dev_upstream branch 3 times, most recently from 3bc36df to 35ca64d Mar 11, 2019

@ndswartz ndswartz force-pushed the ndswartz:storagepool_dev_upstream branch from 58b0857 to 911c76a Mar 12, 2019

@ansibot ansibot added the stale_ci label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.