Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOTMETA: Add Cisco integration/unit tests #53654

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
4 participants
@dagwieers
Copy link
Member

dagwieers commented Mar 11, 2019

SUMMARY

This PR includes:

  • Add missing Cisco integration/unit tests
  • Add underscore to integration tests
  • Sorting (neighbouring) statements alphabetically
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

Cisco related modules, aci, aireos, asa, ftd, ios, iosxr, meraki, nso, nxos, ucs

@ansibot

This comment was marked as resolved.

Copy link
Contributor

ansibot commented Mar 11, 2019

The test ansible-test sanity --test botmeta [explain] failed with 1 error:

.github/BOTMETA.yml:0:0: Can't find 'test/units/modules/network/aci.*' in this branch

click here for bot help

@dagwieers dagwieers force-pushed the dagwieers:botmeta-cisco branch from 805765b to 4516dd5 Mar 11, 2019

@dagwieers dagwieers force-pushed the dagwieers:botmeta-cisco branch 2 times, most recently from b325414 to 546534d Mar 19, 2019

@dagwieers dagwieers requested a review from gundalow Mar 19, 2019

@dagwieers

This comment has been minimized.

Copy link
Member Author

dagwieers commented Mar 19, 2019

@gundalow Can we merge this ?

@gundalow gundalow merged commit a4cdf0d into ansible:devel Mar 19, 2019

1 check passed

Shippable Run 114718 status is SUCCESS.
Details
@gundalow

This comment has been minimized.

Copy link
Contributor

gundalow commented Mar 19, 2019

Thanks Dag :)

@sivel sivel removed the needs_triage label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.