Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws backup plan #53655

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@ezmac
Copy link
Contributor

ezmac commented Mar 11, 2019

SUMMARY

This is a request for comments

https://docs.aws.amazon.com/en_us/aws-backup/latest/devguide/API_CreateBackupPlan.html

Aws backup consists of backup vaults, backup plans, backup selections, recovery points, and possibly other resources I'm forgetting. Rather than put that in one large module that no one will ever review, I've implemented one smaller module that should be easier to review. That means there will be modules for backup_vault and backup_selection as well. Because I don't need to automate recovery points, I would probably skip that work.

The aws provided documentation is wrong. If you call CreateBackupPlan with a plan that already exists, the existing backupPlanId is returned. What actually happens is AlreadyExistsException. If you try to create a backup plan with the same name as an existing backup plan but a different "document", a new backup plan is created with the same name. My memory is fuzzy, but I believe if you try to update a backup plan using the same document, it returns an exception. It is easy to create multiple plans with the same name. In this case, I took the cowardly way sanity preserving way out, and failed.

This module currently can't delete a backup plan by ID, but ansible currently can't do anything with backup so, whatever. This might be better than nothing. I also have a usable but not correctly documented aws_backup_selection module for a decently usable solution. PR to come when I have recovered from documenting this one.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

aws_backup_plan

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/aws_backup_plan/aliases:0:0: missing alias `shippable/posix/group[1-3]` or `unsupported`

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_backup_plan.py:165:1: E303 too many blank lines (3)

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

@ezmac, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 11, 2019

@Constantin007 @Constantin07 @Deepakkothandan @Etherdaemon @Java1Guy @Madhura-CSI @MichaelBaydoun @Sodki @Zeekin @adq @akazakov @alachaum @amir343 @anryko @bekelchik @brandond @captainkerk @chenl87 @defunctio @dennisconrad @dkhenry @fiunchinho @fivethreeo @flowerysong @garethr @gobins @gunzy83 @gurumaia @hsingh @hyperized @iiibrad @infectsoldier @j-carl @jarv @Java1Guy @jimbydamonk @jmenga @joelthompson @jonhadfield @jonmer85 @joshsouza @jsdalton @jsmartin @kaczynskid @leedm777 @linuxdynasty @loia @lwade @michaeljs1990 @minichate @mjschultz @mmochan @nand0p @naslanidis @nathanwebsterdotme @nerzhul @nickball @orthanc @ozbillwang @piontas @pjodouin @prasadkatti @psykotox @ptux @pwnall @raags @rafaeldriutti @rickmendes @roadmapper @rrey @ryansb @ryansydnor @scicoin-project @scottanderson42 @sdubrul @shepdelacreme @silviud @slapula @steynovich @tastychutney @tgerla @timmahoney @tombamford @tomislacker @tsiganenok @viper233 @whiter @willricardo @wilvk @wimnat @yaakov-github @zacblazic @zbal @zimbatm

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.