Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virt_net modify should fail #53679

Merged
merged 2 commits into from Mar 19, 2019

Conversation

Projects
None yet
4 participants
@torvitas
Copy link
Contributor

torvitas commented Mar 12, 2019

SUMMARY

The modify command should fail if any other xml but a host tag is used. The example should actually use the modify command.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

virt_net

STEPS TO REPRODUCE

Create xml with anything else but a host node on top level.

EXPECTED RESULTS

The module fails saying it cannot handle the xml.

ACTUAL RESULTS

The module passes.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 12, 2019

@Akasurde Akasurde self-assigned this Mar 13, 2019

@Akasurde Akasurde self-requested a review Mar 13, 2019

@Akasurde Akasurde removed the needs_triage label Mar 13, 2019

@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Mar 13, 2019

cc @goneri

@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Mar 13, 2019

@torvitas Thanks for the contribution. Changes LGTM.

@goneri

goneri approved these changes Mar 19, 2019

@goneri

This comment has been minimized.

Copy link
Contributor

goneri commented Mar 19, 2019

shipit

@Akasurde Akasurde merged commit e23b116 into ansible:devel Mar 19, 2019

1 check passed

Shippable Run 113374 status is SUCCESS.
Details
@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Mar 19, 2019

@torvitas Thanks for the PR. @goneri Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.