Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make waiting for init optional for non-thin volumes in netapp netapp_e_volume module #53682

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@ajays20078
Copy link

ajays20078 commented Mar 12, 2019

SUMMARY

Hi,

Currently the script and hence Ansible playbook waits for a long time due to the while loop here, this may be made optional and left to the user if they want to wait for the volume initialisation, the default behaviour while creating a volume is to NOT wait for init but while expansion we are making user wait for INIT. This PR fixes the same by making init optional via wait_for_volume_init flag.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

netapp_e_volume.

@ansibot

This comment has been minimized.

@lmprice

This comment has been minimized.

Copy link
Contributor

lmprice commented Mar 12, 2019

@ajays20078 The patch looks good to me. I asked @ndswartz to check it out and run a few tests on it. If it looks good, we'll give it a +1.

@ansibot ansibot removed the needs_triage label Mar 12, 2019

@ansibot ansibot added the stale_ci label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.