Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old version of gather facts from crashing #53696

Merged
merged 7 commits into from Mar 19, 2019

Conversation

Projects
None yet
5 participants
@carchi8py
Copy link
Contributor

carchi8py commented Mar 12, 2019

SUMMARY

Old version of ONTAP don't have NVME and gather fact would crash for these versions. This fixes that issue only allows NVME facts to be gathered from the version of ONTAP that support it.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

na_ontap_gather_facts.py

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

@lonico

lonico approved these changes Mar 13, 2019

Copy link
Contributor

lonico left a comment

shipit

@thedoubl3j
Copy link
Contributor

thedoubl3j left a comment

bug fix, lgtm. shipit

@gundalow gundalow merged commit f43d97d into ansible:devel Mar 19, 2019

1 check passed

Shippable Run 113445 status is SUCCESS.
Details

catcombo added a commit to catcombo/ansible that referenced this pull request Mar 21, 2019

Fix old version of gather facts from crashing (ansible#53696)
* Revert "changes to clusteR"

This reverts commit 33ee1b7.

* Revert "changes to clusteR"

This reverts commit 33ee1b7.

* Revert "Revert "changes to clusteR""

This reverts commit f1104a3.

* Revert "Revert "changes to clusteR""

This reverts commit f1104a3.

* Revert "documentation changes"

This reverts commit 02c369d.

* Fix gather facts

* Revert "Revert "documentation changes""

This reverts commit 576a9b0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.