Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virt net modify dns configuration #53723

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@torvitas
Copy link
Contributor

torvitas commented Mar 13, 2019

SUMMARY

Enable modification of dns entries.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

virt_net

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 13, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/virt_net.py:308:0: unnecessary-semicolon Unnecessary semicolon

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

lib/ansible/modules/cloud/misc/virt_net.py:308:32: E703 statement ends with a semicolon
lib/ansible/modules/cloud/misc/virt_net.py:310:46: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/misc/virt_net.py:311:46: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/misc/virt_net.py:313:46: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/misc/virt_net.py:314:46: E128 continuation line under-indented for visual indent

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 13, 2019

@torvitas torvitas force-pushed the torvitas:virt_net_modify_dns branch from 9cdcdd9 to d449d82 Mar 13, 2019

@torvitas

This comment has been minimized.

Copy link
Contributor Author

torvitas commented Mar 13, 2019

ready_for_review

@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Mar 13, 2019

cc @goneri

@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Mar 13, 2019

@torvitas Thanks for the contribution. PR #53276 adds unit test for virt_net module. If you don't mind we can wait for this PR to merge first and add a unit test for this change according to #53276. Let me know if you have concern. Thanks.

@ansibot ansibot removed the needs_triage label Mar 13, 2019

@torvitas

This comment has been minimized.

Copy link
Contributor Author

torvitas commented Mar 13, 2019

I am fine with that.

@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Mar 13, 2019

@torvitas Great. Thanks for the help.

Show resolved Hide resolved lib/ansible/modules/cloud/misc/virt_net.py Outdated
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 13, 2019

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

lib/ansible/modules/cloud/misc/virt_net.py:262:81: E227 missing whitespace around bitwise or shift operator
lib/ansible/modules/cloud/misc/virt_net.py:276:85: E227 missing whitespace around bitwise or shift operator
lib/ansible/modules/cloud/misc/virt_net.py:296:81: E227 missing whitespace around bitwise or shift operator
lib/ansible/modules/cloud/misc/virt_net.py:311:86: E227 missing whitespace around bitwise or shift operator
lib/ansible/modules/cloud/misc/virt_net.py:314:86: E227 missing whitespace around bitwise or shift operator

click here for bot help

@ansibot ansibot added the ci_verified label Mar 13, 2019

@torvitas torvitas force-pushed the torvitas:virt_net_modify_dns branch from 7698fad to 0e76309 Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.