Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lenovo cnos static route #53736

Merged
merged 4 commits into from Mar 20, 2019

Conversation

Projects
None yet
3 participants
@amuraleedhar
Copy link
Contributor

amuraleedhar commented Mar 13, 2019

SUMMARY

Introducing new module cnos_static_route to facilitate configuration of ip route on cnos devices.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/modules/network/cnos/cnos_static_route.py
test/integration/targets/cnos_static_route/aliases
test/integration/targets/cnos_static_route/cnos_static_route_sample_hosts
test/integration/targets/cnos_static_route/defaults/main.yaml
test/integration/targets/cnos_static_route/tasks/cli.yaml
test/integration/targets/cnos_static_route/tasks/main.yaml
test/integration/targets/cnos_static_route/tests/cli/basic.yaml
test/units/modules/network/cnos/fixtures/cnos_static_route.cfg
test/units/modules/network/cnos/test_cnos_static_route.py

ANSIBLE VERSION

ansible 2.8.0.dev0 (devel e2b9c36) last updated 2018/10/12 13:58:41 (GMT +550)
config file = /etc/ansible/ansible.cfg
configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /home/ansible/sheru/ansible/lib/ansible
executable location = /home/ansible/sheru/ansible/bin/ansible
python version = 2.7.6 (default, Nov 23 2017, 15:49:48) [GCC 4.8.4]

ADDITIONAL INFORMATION

Unit Test and Integration tests are also added which are succesfully tested with CNOS G8272 with image version 10.9.1

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 13, 2019

@amuraleedhar this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 13, 2019

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/network/cnos/cnos_static_route.py:172:21: undefined-variable Undefined variable 'ipaddress'
lib/ansible/modules/network/cnos/cnos_static_route.py:290:0: trailing-newlines Trailing newlines
test/units/modules/network/cnos/test_cnos_static_route.py:75:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/modules/network/cnos/cnos_static_route.py:200:54: E226 missing whitespace around arithmetic operator
lib/ansible/modules/network/cnos/cnos_static_route.py:201:26: E226 missing whitespace around arithmetic operator
lib/ansible/modules/network/cnos/cnos_static_route.py:290:1: W391 blank line at end of file
test/units/modules/network/cnos/test_cnos_static_route.py:75:1: W391 blank line at end of file

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/cnos/cnos_static_route.py:289:0: E109 Next to last line should be: if __name__ == "__main__":

click here for bot help

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 13, 2019

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/network/cnos/cnos_static_route.py:172:21: undefined-variable Undefined variable 'ipaddress'
lib/ansible/modules/network/cnos/cnos_static_route.py:290:0: trailing-newlines Trailing newlines
test/units/modules/network/cnos/test_cnos_static_route.py:75:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/modules/network/cnos/cnos_static_route.py:200:54: E226 missing whitespace around arithmetic operator
lib/ansible/modules/network/cnos/cnos_static_route.py:201:26: E226 missing whitespace around arithmetic operator
lib/ansible/modules/network/cnos/cnos_static_route.py:290:1: W391 blank line at end of file
test/units/modules/network/cnos/test_cnos_static_route.py:75:1: W391 blank line at end of file

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/cnos/cnos_static_route.py:289:0: E109 Next to last line should be: if __name__ == "__main__":

click here for bot help

@ansibot ansibot added the ci_verified label Mar 13, 2019

@amuraleedhar amuraleedhar force-pushed the amuraleedhar:lenovo-cnos-static-route branch from 8b436a7 to 062ded1 Mar 13, 2019

@ansibot ansibot removed the needs_triage label Mar 19, 2019

@Qalthos Qalthos merged commit e4a1473 into ansible:devel Mar 20, 2019

1 check passed

Shippable Run 114755 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.