Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hcloud_volume module #53745

Open
wants to merge 9 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@cschmitt-hcloud
Copy link

cschmitt-hcloud commented Mar 13, 2019

SUMMARY

Add hcloud volume module

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

hcloud_volume

ADDITIONAL INFORMATION

Follow up of #53062 and #52553.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 13, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 13, 2019

@cschmitt-hcloud this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

cschmitt-hcloud and others added some commits Mar 13, 2019

Apply suggestions from code review
Fix test names

Co-Authored-By: cschmitt-hcloud <47825810+cschmitt-hcloud@users.noreply.github.com>

@cschmitt-hcloud cschmitt-hcloud force-pushed the cschmitt-hcloud:add_hcloud_volume branch from 84181ec to 7805acf Mar 13, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 13, 2019

@LKaemmerling @LKaemmerling

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@LKaemmerling

This comment has been minimized.

Copy link
Contributor

LKaemmerling commented Mar 14, 2019

/cc @resmo

@resmo
Copy link
Member

resmo left a comment

thanks, looks pretty good. I am missing the idempotecy tests. After having them added I don't see anying holding us back from merging this into 2.8

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 14, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:205:0: syntax-error unexpected unindent (&lt;unknown&gt;, line 205)

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 779, in <module>
    main()
  File "../bin/plugin_formatter.py", line 734, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 294, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 105, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 40, in read_docstring
    M = ast.parse(b_module_data.read())
  File "/usr/lib/python3.6/ast.py", line 35, in parse
    return compile(source, filename, mode, PyCF_ONLY_AST)
  File "<unknown>", line 205
    +              self.module.warn("Shrinking of volumes is not supported")
    ^
IndentationError: expected an indented block
make: *** [modules] Error 1

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:205:0: SyntaxError: +              self.module.warn("Shrinking of volumes is not supported")

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:205:0: SyntaxError: +              self.module.warn("Shrinking of volumes is not supported")

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:205:0: SyntaxError: +              self.module.warn("Shrinking of volumes is not supported")

The test ansible-test sanity --test compile --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:205:0: SyntaxError: +              self.module.warn("Shrinking of volumes is not supported")

The test ansible-test sanity --test compile --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:205:0: SyntaxError: +              self.module.warn("Shrinking of volumes is not supported")

The test ansible-test sanity --test compile --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:205:0: SyntaxError: +              self.module.warn("Shrinking of volumes is not supported")

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:205:0: IndentationError: expected an indented block

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:205:0: IndentationError: expected an indented block

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:205:0: IndentationError: expected an indented block

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:205:0: IndentationError: expected an indented block

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:205:0: IndentationError: expected an indented block

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:205:0: IndentationError: expected an indented block

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:205:1: E112 expected an indented block
lib/ansible/modules/cloud/hcloud/hcloud_volume.py:205:1: E305 expected 2 blank lines after class or function definition, found 0
lib/ansible/modules/cloud/hcloud/hcloud_volume.py:207:9: E113 unexpected indentation
lib/ansible/modules/cloud/hcloud/hcloud_volume.py:229:5: E901 IndentationError: unindent does not match any outer indentation level

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:0:0: E401 Python SyntaxError while parsing module

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:205:0: python-syntax-error expected an indented block (<unknown>, line 205)

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 15, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_volume.py:0:0: E319 RETURN.hcloud_volume.contains: required key not provided @ data['hcloud_volume']['contains']. Got None

click here for bot help

Christopher Schmitt
Christopher Schmitt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.