Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IndicatorLED control commands to redfish_command module #53752

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@xmadsen
Copy link
Contributor

xmadsen commented Mar 13, 2019

SUMMARY

This pull request adds functionality to control a system's indicator LED via the redfish_command module. This adds a Chassis category with new commands IndicatorLedOn, IndicatorLedOff, and IndicatorLedBlink. The design currently only allows a single LED command to be sent in a single task, since in a list of commands only the last one would take effect if they were executed in order, since each necessarily configures a single state of the LED.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

redfish_command

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

@billdodd
Copy link
Contributor

billdodd left a comment

Thanks for the PR @xmadsen!

I do have a couple of small suggestions. See inline comments below

@ansibot ansibot removed the needs_triage label Mar 18, 2019

Xander Madsen
Add IndicatorLedBlink example to EXAMPLES docstring, and make the cat…
…egory == 'Chassis' section more generic for future development
@billdodd
Copy link
Contributor

billdodd left a comment

@xmadsen - Thanks for making those updates. Looks good.

shipit

@jose-delarosa

This comment has been minimized.

Copy link
Contributor

jose-delarosa commented Mar 21, 2019

Thanks for the PR @xmadsen. I'm curious, where is this indicator LED on exactly? Is it the server's main status LED?

Working from home today, might be in the lab tomorrow. Will need to go into office to test.

@xmadsen

This comment has been minimized.

Copy link
Contributor Author

xmadsen commented Mar 21, 2019

@jose-delarosa This is the usually-blue LED used for identifying a server in a rack, whose state is reflected in an LED in the front of the server and an LED in the back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.