Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of network agnostic modules in use #53755

Open
wants to merge 4 commits into
base: devel
from

Conversation

@samccann
Copy link
Contributor

samccann commented Mar 13, 2019

SUMMARY

Add an example of using network agnostic modules to networking guide.

Fixes #53013

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs.ansible.com

ADDITIONAL INFORMATION

@samccann samccann added this to Needs Triage - todo backlog - Docsite work -anything can go here in Network Documentation via automation Mar 13, 2019

@samccann samccann moved this from Needs Triage - todo backlog - Docsite work -anything can go here to In progress in Network Documentation Mar 13, 2019

@samccann samccann moved this from In progress to Waiting review/merge in Network Documentation Mar 13, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 13, 2019

@acozine
Copy link
Contributor

acozine left a comment

Overall this looks great. Lots of fixes and edits, plus a great new example.

I noted a few places where it could be made even better.

Show resolved Hide resolved docs/docsite/rst/network/user_guide/network_best_practices_2.5.rst
Show resolved Hide resolved docs/docsite/rst/network/user_guide/network_best_practices_2.5.rst
@@ -366,14 +406,10 @@ Note that when using variables from tasks in this way we use double quotes (``"`
Troubleshooting
===============

If you receive an connection error please double check the inventory and Playbook for typos or missing lines. If the issue still occurs follow the debug steps in :doc:`network_debug_troubleshooting`.
If you receive an connection error please double check the inventory and Playbook for typos or missing lines. If the issue still occurs follow the debug steps in :ref:`network_debug_troubleshooting`.

This comment has been minimized.

@kbreit

kbreit Mar 20, 2019

Contributor

Playbook should be lowercase.

gather_facts: false
tasks:
- name: Run show command

This comment has been minimized.

@ganeshrn

ganeshrn Mar 20, 2019

Member

Probably can also add an example to work with multiple prompts. Since currently, only cli_command support multi prompt scenario will be good to have in the doc

This comment has been minimized.

@samccann

samccann Mar 20, 2019

Author Contributor

@ganeshrn can you point me to an example of this that I can add here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.