Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXOS httpapi plugin and exos_vlan module #53762

Open
wants to merge 10 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@ujwalkomarla
Copy link

ujwalkomarla commented Mar 13, 2019

SUMMARY
  • Add httpapi support for EXOS NOS devices
  • Add exos_vlan module with basic unit tests.
  • Add support for cli_config module.
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

exos_vlan

ADDITIONAL INFORMATION
  • The httapi plugin will support communication with EXOS devices over JSONRPC or RESTCONF protocol.
  • exos_facts, exos_command, exos_config modules can use either the network-cli or httpapi(JSONRPC) connection.
  • exos_vlan module will be only through httpapi(RESTCONF) connection.
  • Tested against standalone x460-g2, two-node stack of x460-g2 Stack, and an EXOS VM.
RESTCONF LIMITATION

RESTCONF is supported with EXOS v22.1 and later releases.
RESTCONF is packaged into EXOS starting with v22.4.
Releases can be found at https://github.com/extremenetworks/EXOS_Apps/tree/master/REST/downloads

ANSIBLE VERSION

ansible 2.8.0.dev0
  config file = /Users/ukomarla/.ansible.cfg
  configured module search path = ['/Users/ukomarla/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/ukomarla/ansible/lib/ansible
  executable location = /Users/ukomarla/ansible/bin/ansible
  python version = 3.7.2 (v3.7.2:9a3ffc0492, Dec 24 2018, 02:44:43) [Clang 6.0 (clang-600.0.57)]

@ujwalkomarla ujwalkomarla force-pushed the ujwalkomarla:EXOS_HTTPAPI_VLAN branch from 3f0bf4e to b456b26 Mar 14, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 14, 2019

@ujwalkomarla, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@samccann
Copy link
Contributor

samccann left a comment

docs portion LGTM

@ansibot ansibot removed the needs_triage label Mar 14, 2019

@ujwalkomarla ujwalkomarla force-pushed the ujwalkomarla:EXOS_HTTPAPI_VLAN branch 2 times, most recently from 1100315 to 8305f0d Mar 15, 2019

@ansibot

This comment was marked as resolved.

Copy link
Contributor

ansibot commented Mar 15, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

test/units/modules/network/exos/test_exos_vlan.py:66:33: E126 continuation line over-indented for hanging indent
test/units/modules/network/exos/test_exos_vlan.py:74:29: E126 continuation line over-indented for hanging indent

The test ansible-test sanity --test validate-modules [explain] failed with 6 errors:

lib/ansible/modules/network/exos/exos_config.py:0:0: E324 Argument 'diff_against' in argument_spec defines default as ('running') but documentation defines default as (None)
lib/ansible/modules/network/exos/exos_vlan.py:0:0: E319 RETURN.commands: expected a dictionary for dictionary value @ data['commands']. Got None
lib/ansible/modules/network/exos/exos_vlan.py:0:0: E319 RETURN.description: expected a dictionary for dictionary value @ data['description']. Got 'Configuration difference in terms of POST, PATCH and DELETE requests'
lib/ansible/modules/network/exos/exos_vlan.py:0:0: E319 RETURN.returned: expected a dictionary for dictionary value @ data['returned']. Got 'when configuration is changed'
lib/ansible/modules/network/exos/exos_vlan.py:0:0: E319 RETURN.sample: expected a dictionary for dictionary value @ data['sample']. Got '[\n  {\n    "data": {\n      "openconfig-vlan:vlan": [\n        {\n          "config": {\n            "name": "ansible_100",\n            "status": "ACTIVE",\n            "tpid": "oc-vlan-types:TPID_0x8100",\n            "vlan-id": 100\n          }\n        }\n      ]\n    },\n    "method": "POST",\n    "path": "/rest/restconf/data/openconfig-vlan:vlans/"\n  },\n  {\n    "data": {\n      "openconfig-vlan:vlan": [\n        {\n          "config": {\n            "name": "ansible_200",\n        ...
lib/ansible/modules/network/exos/exos_vlan.py:0:0: E319 RETURN.type: expected a dictionary for dictionary value @ data['type']. Got 'list'

click here for bot help

@ujwalkomarla ujwalkomarla force-pushed the ujwalkomarla:EXOS_HTTPAPI_VLAN branch from 8305f0d to 654c474 Mar 15, 2019

@ansibot ansibot added needs_rebase and removed ci_verified labels Mar 15, 2019

@ujwalkomarla ujwalkomarla force-pushed the ujwalkomarla:EXOS_HTTPAPI_VLAN branch from 654c474 to e3f83a8 Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.