Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mandatory_tags and exclude_tags for scaleway #53767

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
6 participants
@Sh4d1
Copy link

Sh4d1 commented Mar 13, 2019

Signed-off-by: Patrik Cyvoct patrik@ptrk.io

SUMMARY

Add the possibilty to add mandatory tags and to exclude tags in Scaleway's dynamic inventory

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/plugins/inventory/scaleway.py

ADDITIONAL INFORMATION

cc @sieben

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 13, 2019

@ansibot ansibot removed the needs_triage label Mar 14, 2019

@Sh4d1 Sh4d1 force-pushed the Sh4d1:update_scaleway_inventory branch from 69a58b8 to f6739ea Mar 14, 2019

@abarbare

This comment has been minimized.

Copy link
Contributor

abarbare commented Mar 14, 2019

shipit

@bcoca

This comment has been minimized.

Copy link
Member

bcoca commented Mar 14, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 14, 2019

Components

lib/ansible/plugins/inventory/scaleway.py
support: community
maintainers: Anthony25 Spredzy abarbare pilou- sieben

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): abarbare
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@Anthony25
Copy link
Contributor

Anthony25 left a comment

exclude_tags seems to be a good idea, but I'm not sure about the mendatory_tags, it seems redundant with tags

Show resolved Hide resolved lib/ansible/plugins/inventory/scaleway.py Outdated
Show resolved Hide resolved lib/ansible/plugins/inventory/scaleway.py Outdated
Show resolved Hide resolved lib/ansible/plugins/inventory/scaleway.py
Show resolved Hide resolved lib/ansible/plugins/inventory/scaleway.py
Add mandatory_tags and exclude_tags for scaleway
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>

@Sh4d1 Sh4d1 force-pushed the Sh4d1:update_scaleway_inventory branch from f6739ea to eca69a5 Mar 14, 2019

@Anthony25

This comment has been minimized.

Copy link
Contributor

Anthony25 commented Mar 14, 2019

shipit

@Sh4d1

This comment has been minimized.

Copy link
Author

Sh4d1 commented Mar 19, 2019

@bcoca good?

@sieben

This comment has been minimized.

Copy link
Contributor

sieben commented Mar 20, 2019

@gundalow Could you merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.