Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing status option in documentation #53785

Merged
merged 3 commits into from Mar 21, 2019

Conversation

Projects
None yet
5 participants
@bencart
Copy link
Contributor

bencart commented Mar 14, 2019

changing status option to statuses in the documentation

+label: docsite_pr

SUMMARY

Documentation currently has "status" option when it is actually "statuses"

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

aws_acm_facts

ADDITIONAL INFORMATION
fixing status option in documentation
changing status option to statuses in the documentation

+label: docsite_pr
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 14, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 14, 2019

@bencart, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 14, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/cloud/amazon/aws_acm_facts.py:0:0: E309 version_added for new option (statuses) should be '2.8'. Currently StrictVersion ('0.0')
lib/ansible/modules/cloud/amazon/aws_acm_facts.py:0:0: E326 Argument 'statuses' in argument_spec defines choices as ([]) but documentation defines choices as ([['PENDING_VALIDATION'], ['ISSUED'], ['INACTIVE'], ['EXPIRED'], ['VALIDATION_TIMED_OUT']])
test/sanity/validate-modules/ignore.txt:3:1: A102 Remove since "lib/ansible/modules/cloud/amazon/aws_acm_facts.py" passes "E322" test
test/sanity/validate-modules/ignore.txt:4:1: A102 Remove since "lib/ansible/modules/cloud/amazon/aws_acm_facts.py" passes "E323" test

click here for bot help

@ansibot ansibot removed the needs_triage label Mar 14, 2019

@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Mar 15, 2019

@bencart Could you please address these issues -

lib/ansible/modules/cloud/amazon/aws_acm_facts.py:0:0: E326 Argument 'statuses' in argument_spec defines choices as ([]) but documentation defines choices as ([['PENDING_VALIDATION'], ['ISSUED'], ['INACTIVE'], ['EXPIRED'], ['VALIDATION_TIMED_OUT']])
test/sanity/validate-modules/ignore.txt:3:1: A102 Remove since "lib/ansible/modules/cloud/amazon/aws_acm_facts.py" passes "E322" test
test/sanity/validate-modules/ignore.txt:4:1: A102 Remove since "lib/ansible/modules/cloud/amazon/aws_acm_facts.py" passes "E323" test
changing statuses option choices to match AWS
Adding choices to the argument spec to match the documentation from AWS.
Adding 'REVOKED', 'FAILED' to statuses documentation to match implementation.
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 15, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/cloud/amazon/aws_acm_facts.py:0:0: E309 version_added for new option (statuses) should be '2.8'. Currently StrictVersion ('0.0')
test/sanity/validate-modules/ignore.txt:3:1: A102 Remove since "lib/ansible/modules/cloud/amazon/aws_acm_facts.py" passes "E322" test
test/sanity/validate-modules/ignore.txt:4:1: A102 Remove since "lib/ansible/modules/cloud/amazon/aws_acm_facts.py" passes "E323" test

click here for bot help

@ansibot ansibot added the ci_verified label Mar 15, 2019

Removing ignores for aws_acm_facts
Removing E322, E323 ignores for aws_acm_facts
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 15, 2019

@ansibot ansibot added support:core test and removed ci_verified labels Mar 15, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 15, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_acm_facts.py:0:0: E309 version_added for new option (statuses) should be '2.8'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot ansibot added the ci_verified label Mar 15, 2019

@acozine

This comment has been minimized.

Copy link
Contributor

acozine commented Mar 21, 2019

Merged despite a failing test - the failure is only due to a mismatch in the version_added field for the statuses parameter. The parameter has always been there; only the correction is being added in 2.8.

@acozine

This comment has been minimized.

Copy link
Contributor

acozine commented Mar 21, 2019

Thanks @bencart for catching and fixing that error.

@acozine acozine merged commit f99f88b into ansible:devel Mar 21, 2019

1 check failed

Shippable Run 114114 status is FAILED.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.