Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: Kibana saved object #53796

Open
wants to merge 11 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@rubentsirunyan
Copy link
Contributor

rubentsirunyan commented Mar 14, 2019

SUMMARY

Created a new module for interacting with Kibana saved object
API documentation

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

kibana_saved_object

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 14, 2019

The test ansible-test sanity --test pylint [explain] failed with 13 errors:

lib/ansible/modules/database/misc/kibana_saved_object.py:173:10: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/database/misc/kibana_saved_object.py:221:33: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/database/misc/kibana_saved_object.py:244:29: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/database/misc/kibana_saved_object.py:266:29: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/database/misc/kibana_saved_object.py:286:29: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/database/misc/kibana_saved_object.py:307:33: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/database/misc/kibana_saved_object.py:309:29: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/database/misc/kibana_saved_object.py:381:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/database/misc/kibana_saved_object.py:385:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/database/misc/kibana_saved_object.py:400:33: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/database/misc/kibana_saved_object.py:414:33: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/database/misc/kibana_saved_object.py:419:33: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/database/misc/kibana_saved_object.py:432:33: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test validate-modules [explain] failed with 10 errors:

lib/ansible/modules/database/misc/kibana_saved_object.py:0:0: E322 Argument 'force' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/database/misc/kibana_saved_object.py:0:0: E322 Argument 'http_agent' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/database/misc/kibana_saved_object.py:0:0: E322 Argument 'socks_proxy' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/database/misc/kibana_saved_object.py:0:0: E322 Argument 'thirsty' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/database/misc/kibana_saved_object.py:0:0: E322 Argument 'url' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/database/misc/kibana_saved_object.py:0:0: E322 Argument 'url_password' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/database/misc/kibana_saved_object.py:0:0: E322 Argument 'url_username' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/database/misc/kibana_saved_object.py:0:0: E322 Argument 'use_proxy' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/database/misc/kibana_saved_object.py:0:0: E324 Argument 'http_agent' in argument_spec defines default as ('ansible-httpget') but documentation defines default as (None)
lib/ansible/modules/database/misc/kibana_saved_object.py:0:0: E324 Argument 'use_proxy' in argument_spec defines default as (True) but documentation defines default as (False)

click here for bot help

@ansibot ansibot removed the ci_verified label Mar 14, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 14, 2019

@ThePixelDeveloper @barryib @drewkerrigan @jsmartin @slok

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 15, 2019

The test ansible-test sanity --test no-underscore-variable [explain] failed with 2 errors:

lib/ansible/modules/database/misc/kibana_saved_object.py:209:19: use `dummy` instead of `_` for a variable name
lib/ansible/modules/database/misc/kibana_saved_object.py:272:19: use `dummy` instead of `_` for a variable name

click here for bot help

@ansibot ansibot added the ci_verified label Mar 15, 2019

@ansibot ansibot removed the ci_verified label Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.