Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-2.7] Correctly count processors on ARM systems. (#52884) #53798

Merged
merged 2 commits into from Mar 18, 2019

Conversation

Projects
None yet
5 participants
@samdoran
Copy link
Member

samdoran commented Mar 14, 2019

SUMMARY

Backport of #52884 for Ansible 2.7

(cherry picked from commit 5530690)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/facts/hardware/linux.py

samdoran added some commits Mar 14, 2019

[stable-2.7] Correctly count processors on ARM systems. (#52884)
- Add unit tests for Linux CPU info
- Add cpuinfo output from several systems for unit tests

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 5530690)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@dagwieers

This comment has been minimized.

Copy link
Member

dagwieers commented Mar 14, 2019

As discussed in another PR, I think it could be worthwhile to add integration tests to compare lscpu output with our implementation.

If for some reason the kernel proc information changes, we can tell if we end up with different counts than lscpu. (Which doesn't indicate if we or lscpu are doing it wrong, but at least we can easily test for this)

@dagwieers
Copy link
Member

dagwieers left a comment

LGTM

@ansibot ansibot added shipit and removed core_review labels Mar 14, 2019

@abadger abadger merged commit 833b29b into ansible:stable-2.7 Mar 18, 2019

1 check passed

Shippable Run 113890 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

abadger commented Mar 18, 2019

Merged for 2.7.10

@sivel sivel removed the needs_triage label Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.