Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move _text functions into module_utils.text.formatters #53833

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@samdoran
Copy link
Member

samdoran commented Mar 15, 2019

SUMMARY

Move all functions in lib/ansible/module_utils/_text.py to lib/ansible/module_utils/common/text/formatters.py.

Leave a backwards compatible import in lib/ansible/module_utils/_text.py.

This lays the groundwork for changing all references to lib/ansible/module_utils/_text.py in a future PR.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/module_utils/_text.py
lib/ansible/module_utils/common/text/formatters.py

ADDITIONAL INFORMATION

This will need to be rebased after #53687 is merged as it dovetails with that work.

@samdoran

This comment has been minimized.

Copy link
Member Author

samdoran commented Mar 15, 2019

bot_skip

@samdoran samdoran requested review from abadger , sivel , bcoca and nitzmahone Mar 15, 2019

@samdoran samdoran changed the title Move _text functions into module_utils.text.formatters [WIP] Move _text functions into module_utils.text.formatters Mar 15, 2019

@openstack-zuul

This comment has been minimized.

Copy link

openstack-zuul bot commented Mar 15, 2019

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@mattclay

This comment has been minimized.

Copy link
Member

mattclay commented Mar 18, 2019

@samdoran I recommend splitting this PR up into multiple parts to make it easier to review. Start with moving the functions and the backwards compatibility stub. Then follow up with separate PRs for migrations, keeping the migrations reasonably sized.

@samdoran

This comment has been minimized.

Copy link
Member Author

samdoran commented Mar 18, 2019

@mattclay Sounds like a plan. Thank you for the feedback.

@samdoran samdoran force-pushed the samdoran:move_text_to_common_text_formatters branch 3 times, most recently from cabd36a to ef3fd17 Mar 19, 2019

@samdoran samdoran force-pushed the samdoran:move_text_to_common_text_formatters branch from ef3fd17 to 358d1fc Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.