Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] docker_container tests: only use ports in the range 9001-9060 #53844

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
4 participants
@felixfontein
Copy link
Contributor

felixfontein commented Mar 15, 2019

SUMMARY

Backport of #53840 to stable-2.7. Only uses ports 9001 to 9003 since port ranges can only be specified in docker_container from 2.8 on.

Mainly needed in case #53816 gets backported to stable-2.7 (or something similar is done), to avoid port clashes. (In fact the problems as in #53816 won't happen here since the 2.7 docker_container tests don't use port 8080, but I think it's nice if all docker_container tests in all Ansible versions use the same range of ports.)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_container

Only use ports in the range 9001-9060.
(cherry picked from commit 77f7e5a)

@abadger abadger merged commit 1cd21e2 into ansible:stable-2.7 Mar 18, 2019

1 check passed

Shippable Run 114079 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

abadger commented Mar 18, 2019

merged for 2.7.10

@felixfontein felixfontein deleted the felixfontein:backport/2.7/53840 branch Mar 18, 2019

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

felixfontein commented Mar 18, 2019

Thanks for merging this and the other PR!

@sivel sivel removed the needs_triage label Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.