Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows - Fix issues with glob like path chars - 2.6 #53845

Merged
merged 7 commits into from Mar 18, 2019

Conversation

Projects
None yet
4 participants
@jborean93
Copy link
Contributor

jborean93 commented Mar 15, 2019

SUMMARY

Backport of #53827
Backport of #53828
Backport of #53829
Backport of #53830
Backport of #53831
Backport of #53835

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_acl
win_acl_inheritance
win_owner
win_slurp
win_tempfile

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 15, 2019

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/win_acl/aliases:0:0: missing alias `shippable/windows/group[1-4]` or `unsupported`

click here for bot help

@jborean93

This comment has been minimized.

Copy link
Contributor Author

jborean93 commented Mar 15, 2019

Tests will fail until #53843 is merged.

jborean93 added some commits Mar 15, 2019

win_tempfile - return absolute path on created temp file (#53827)
* win_tempfile - return absolute path on created temp file

* Fix tests for CI

(cherry picked from commit 4f9de45)
win_acl - fix glob file paths (#53828)
(cherry picked from commit aba6f5f)
win_owner - fix glob like paths (#53830)
* win_owner - fix glob like paths

* Fix issues on older PS versions

(cherry picked from commit d063cef)
win_slurp - fix glob like paths (#53831)
(cherry picked from commit d00418c)
windows - Fix module utils with glob paths (#53835)
* windows - Fix module utils with glob paths

* fix link util tests when using DOS 8.3 paths

(cherry picked from commit 980ca56)

@jborean93 jborean93 force-pushed the jborean93:win-paths-2.6 branch from ea41a80 to 411da46 Mar 16, 2019

@ansibot ansibot added core_review and removed needs_revision labels Mar 16, 2019

@abadger abadger merged commit 0429b10 into ansible:stable-2.6 Mar 18, 2019

1 check passed

Shippable Run 114243 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

abadger commented Mar 18, 2019

Merged for 2.6.16

@jborean93 jborean93 deleted the jborean93:win-paths-2.6 branch Mar 18, 2019

@sivel sivel removed the needs_triage label Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.