Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inventory: vultr: implement keyed groups and filter #53869

Merged
merged 5 commits into from Mar 19, 2019

Conversation

Projects
None yet
4 participants
@resmo
Copy link
Member

resmo commented Mar 15, 2019

SUMMARY

implement keyed groups and filter. This supersedes #53165. Closes #53165

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vultr

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 15, 2019

@resmo resmo force-pushed the resmo:feautre/vultr_inventory branch from 9b40a7d to 5f7f65f Mar 16, 2019

@resmo resmo force-pushed the resmo:feautre/vultr_inventory branch from 5f7f65f to e46f5bf Mar 18, 2019

@Spredzy
Copy link
Contributor

Spredzy left a comment

Small nit but LGTM otherwise

Show resolved Hide resolved lib/ansible/plugins/inventory/vultr.py
for server in _retrieve_servers(api_key):

# Add a top group 'vultr'
self.inventory.add_group(group='vultr')

This comment has been minimized.

@Spredzy

Spredzy Mar 18, 2019

Contributor

👍

description:
- Get inventory hosts from Vultr public cloud.
- Uses C(api_config), C(~/.vultr.ini), C(./vultr.ini) or VULTR_API_CONFIG path to config file.
- Uses I(api_config), I(~/.vultr.ini), I(./vultr.ini) or C(VULTR_API_CONFIG) path to config file.

This comment has been minimized.

@bcoca

bcoca Mar 18, 2019

Member

inventory source file naming requirements?

Show resolved Hide resolved lib/ansible/plugins/inventory/vultr.py Outdated

@ansibot ansibot added needs_revision and removed shipit labels Mar 18, 2019

@resmo

This comment has been minimized.

Copy link
Member Author

resmo commented Mar 18, 2019

Thanks @bcoca and @Spredzy for the review!

@resmo resmo requested a review from bcoca Mar 18, 2019

@bcoca

bcoca approved these changes Mar 18, 2019

@resmo resmo merged commit ab23807 into ansible:devel Mar 19, 2019

1 check passed

Shippable Run 114590 status is SUCCESS.
Details

@resmo resmo deleted the resmo:feautre/vultr_inventory branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.