Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing roles to the team_role module #53870

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@sergioperez
Copy link

sergioperez commented Mar 15, 2019

SUMMARY

Some organization roles were missing at tower_role

"project_admin", "inventory_admin", "credential_admin", "workflow_admin","notification_admin"

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

tower_role module

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 15, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/ansible_tower/tower_role.py:117:100: bad-whitespace Exactly one space required after comma                             "project_admin", "inventory_admin", "credential_admin", "workflow_admin","notification_admin"]),                                                                                                     ^

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/web_infrastructure/ansible_tower/tower_role.py:117:29: E127 continuation line over-indented for visual indent
lib/ansible/modules/web_infrastructure/ansible_tower/tower_role.py:117:101: E231 missing whitespace after ','

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/ansible_tower/tower_role.py:0:0: E326 Argument 'role' in argument_spec defines choices as (['admin', 'read', 'member', 'execute', 'adhoc', 'update', 'use', 'auditor', 'project_admin', 'inventory_admin', 'credential_admin', 'workflow_admin', 'notification_admin']) but documentation defines choices as (['admin', 'read', 'member', 'execute', 'adhoc', 'update', 'use', 'auditor'])

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.