Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong `date_size` skip logic in s3_sync module #53935

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@issei-m
Copy link

commented Mar 18, 2019

SUMMARY

While the documentation of s3_sync claims setting file_change_strategy as date_size will upload if file sizes don't match or if local file modified date is newer than s3's version but the implementation doesn't look like that.
In the current implementation, the file which is the same size as s3's version won't be uploaded even if the local file has a newer modified epoch than s3's one.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • s3_sync
ADDITIONAL INFORMATION

n/a

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

@issei-m, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.